Re: [PATCH] iio: magnetometer: ak8975: Add AK8963

[Jonathan Cameron <jic23@kernel.org>]

On 09/01/15 23:30, Srinivas Pandruvada wrote:
> Added AK8963 in the id table. Unfortunately some commercial devices
> using caps version ak8963.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Hmm. I'm not sure what the general opinion on supporting this sort of
mess up is.

Are we talking naming provided from a device tree or via old fashioned board
files?  If the board files I'd be inclined to say they are running a custom
kernel anyway so can patch this driver themselves.  If device tree I guess
we probably do need to support it - perhaps as a deprecated binding?

Wolfram / Jean - you guys must have seen this before. Did you let
the capital form in alongside the lower case one?  I guessing no ;)

I did a quick grep of hwmon and couldn't find any instances of this...

Jonathan
> ---
>  drivers/iio/magnetometer/ak8975.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c
> index 0d10a4b..b13936d 100644
> --- a/drivers/iio/magnetometer/ak8975.c
> +++ b/drivers/iio/magnetometer/ak8975.c
> @@ -813,6 +813,7 @@ static int ak8975_probe(struct i2c_client *client,
>  static const struct i2c_device_id ak8975_id[] = {
>  	{"ak8975", AK8975},
>  	{"ak8963", AK8963},
> +	{"AK8963", AK8963},
>  	{"ak09911", AK09911},
>  	{"ak09912", AK09912},
>  	{}
>