From: Hans de Goede <hdegoede@redhat.com>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] acpi-video: Add disable_native_backlight quirk for Dell XPS15 L521X
Date: Sun, 11 Jan 2015 11:37:52 +0100 [thread overview]
Message-ID: <54B25280.6010604@redhat.com> (raw)
In-Reply-To: <20150111061602.GA1677@srcf.ucam.org>
Hi,
On 11-01-15 07:16, Matthew Garrett wrote:
> On Mon, Jan 05, 2015 at 08:57:04AM +0100, Hans de Goede wrote:
>> The L521X variant of the Dell XPS15 has integrated nvidia graphics, and
>> backlight control does not work properly when using the native interfaces.
>
> I'm not convinced that the assessment of this bug is correct. Is the
> system using the nvidia graphics device?
I do not know.
> If so, why is userspace writing to the intel backlight device?
Userspace is writing to the intel_backlight device because it is the
only one present under /sys/class/backlight, as we disable acpi-video
on win8 ready laptops by default now.
What this commit does is disable the disabling of acpi-video, and
after that userspace will see an acpi_video0 backlight under
/sys/class/backlight, use that and then things work, this has been
confirmed by the bug reporter.
The commit message may not be 100% accurate, although I believe this is
related to the laptop having nvidia graphics, but the code / fix is correct
regardless.
Regards,
Hans
next prev parent reply other threads:[~2015-01-11 10:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 7:57 [PATCH] acpi-video: Add disable_native_backlight quirk for Dell XPS15 L521X Hans de Goede
2015-01-05 23:35 ` Rafael J. Wysocki
2015-01-11 6:16 ` Matthew Garrett
2015-01-11 10:37 ` Hans de Goede [this message]
2015-01-12 2:44 ` Matthew Garrett
2015-01-12 9:12 ` Hans de Goede
2015-01-12 10:21 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B25280.6010604@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.