From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5556132467821196756==" MIME-Version: 1.0 From: Oded Gabbay To: lkp@lists.01.org Subject: Re: [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel Date: Sun, 11 Jan 2015 13:57:59 +0200 Message-ID: <54B26547.2030400@amd.com> In-Reply-To: <87mw5v4iug.fsf@rustcorp.com.au> List-Id: --===============5556132467821196756== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On 01/07/2015 12:58 AM, Rusty Russell wrote: > Kees Cook writes: >> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell = wrote: >>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs >>> section for weak symbols. These should not be relocated if already 0. >> >> A few questions: >> >> Why doesn't this break on 32-bit without kASLR? 32-bit does relocation >> by default, even without CONFIG_RANDOMIZE_BASE. > = > Well, the offset was 0 until I removed CONFIG_HIBERNATE. > = >> Are there any symbols that are NULL that aren't weak? I'd expect all >> strong symbols to have non-zero offsets, but I must be >> misunderstanding something here. > = > I don't think there would be. Anyway, you might be able to filter them > out in x86/tools/relocs itself. > = > Cheers, > Rusty. > = Hi Kees, Did you had time to look at the problem ? Oded --===============5556132467821196756==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oded Gabbay Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel Date: Sun, 11 Jan 2015 13:57:59 +0200 Message-ID: <54B26547.2030400@amd.com> References: <1419246673-7222-1-git-send-email-oded.gabbay@amd.com> <20141222184940.GB17192@tassilo.jf.intel.com> <20141222190041.GC17192@tassilo.jf.intel.com> <54986EA2.106@amd.com> <874msmt1hi.fsf@rustcorp.com.au> <549A85DE.1040006@amd.com> <87r3v96ebd.fsf@rustcorp.com.au> <87mw5v4iug.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from na01-by2-obe.outbound.protection.outlook.com (mail-by2on0134.outbound.protection.outlook.com [207.46.100.134]) by gabe.freedesktop.org (Postfix) with ESMTP id E33686E299 for ; Sun, 11 Jan 2015 03:58:08 -0800 (PST) In-Reply-To: <87mw5v4iug.fsf@rustcorp.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kees Cook Cc: Andi Kleen , "H. Peter Anvin" , Rusty Russell , LKML , Maling list - DRI developers , Alexander Deucher , LKP ML List-Id: dri-devel@lists.freedesktop.org CgpPbiAwMS8wNy8yMDE1IDEyOjU4IEFNLCBSdXN0eSBSdXNzZWxsIHdyb3RlOgo+IEtlZXMgQ29v ayA8a2Vlc2Nvb2tAY2hyb21pdW0ub3JnPiB3cml0ZXM6Cj4+IE9uIFN1biwgSmFuIDQsIDIwMTUg YXQgODoyOCBQTSwgUnVzdHkgUnVzc2VsbCA8cnVzdHlAcnVzdGNvcnAuY29tLmF1PiB3cm90ZToK Pj4+IEtlZXMsIGFzIGZhciBhcyBJIGNhbiB0ZWxsIHlvdSBuZWVkIGFub3RoZXIgMC10ZXJtaW5h dGVkIHZtbGludXgucmVsb2NzCj4+PiBzZWN0aW9uIGZvciB3ZWFrIHN5bWJvbHMuICBUaGVzZSBz aG91bGQgbm90IGJlIHJlbG9jYXRlZCBpZiBhbHJlYWR5IDAuCj4+Cj4+IEEgZmV3IHF1ZXN0aW9u czoKPj4KPj4gV2h5IGRvZXNuJ3QgdGhpcyBicmVhayBvbiAzMi1iaXQgd2l0aG91dCBrQVNMUj8g MzItYml0IGRvZXMgcmVsb2NhdGlvbgo+PiBieSBkZWZhdWx0LCBldmVuIHdpdGhvdXQgQ09ORklH X1JBTkRPTUlaRV9CQVNFLgo+IAo+IFdlbGwsIHRoZSBvZmZzZXQgd2FzIDAgdW50aWwgSSByZW1v dmVkIENPTkZJR19ISUJFUk5BVEUuCj4gCj4+IEFyZSB0aGVyZSBhbnkgc3ltYm9scyB0aGF0IGFy ZSBOVUxMIHRoYXQgYXJlbid0IHdlYWs/IEknZCBleHBlY3QgYWxsCj4+IHN0cm9uZyBzeW1ib2xz IHRvIGhhdmUgbm9uLXplcm8gb2Zmc2V0cywgYnV0IEkgbXVzdCBiZQo+PiBtaXN1bmRlcnN0YW5k aW5nIHNvbWV0aGluZyBoZXJlLgo+IAo+IEkgZG9uJ3QgdGhpbmsgdGhlcmUgd291bGQgYmUuICBB bnl3YXksIHlvdSBtaWdodCBiZSBhYmxlIHRvIGZpbHRlciB0aGVtCj4gb3V0IGluIHg4Ni90b29s cy9yZWxvY3MgaXRzZWxmLgo+IAo+IENoZWVycywKPiBSdXN0eS4KPiAKCkhpIEtlZXMsCgpEaWQg eW91IGhhZCB0aW1lIHRvIGxvb2sgYXQgdGhlIHByb2JsZW0gPwoKCU9kZWQKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752092AbbAKL6M (ORCPT ); Sun, 11 Jan 2015 06:58:12 -0500 Received: from mail-by2on0138.outbound.protection.outlook.com ([207.46.100.138]:12000 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750807AbbAKL6J (ORCPT ); Sun, 11 Jan 2015 06:58:09 -0500 X-WSS-ID: 0NI0H8R-08-LPR-02 X-M-MSG: Message-ID: <54B26547.2030400@amd.com> Date: Sun, 11 Jan 2015 13:57:59 +0200 From: Oded Gabbay Organization: AMD User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Kees Cook CC: Rusty Russell , Andi Kleen , Alex Deucher , "H. Peter Anvin" , "Dana Elifaz" , LKML , "Maling list - DRI developers" , Alexander Deucher , LKP ML Subject: Re: [LKP] [PATCH] drm/radeon: Try to init amdkfd only if 64 bit kernel References: <1419246673-7222-1-git-send-email-oded.gabbay@amd.com> <20141222184940.GB17192@tassilo.jf.intel.com> <20141222190041.GC17192@tassilo.jf.intel.com> <54986EA2.106@amd.com> <874msmt1hi.fsf@rustcorp.com.au> <549A85DE.1040006@amd.com> <87r3v96ebd.fsf@rustcorp.com.au> <87mw5v4iug.fsf@rustcorp.com.au> In-Reply-To: <87mw5v4iug.fsf@rustcorp.com.au> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.224.11.83] X-EOPAttributedMessage: 0 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Oded.Gabbay@amd.com; X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(51704005)(199003)(377454003)(189002)(52314003)(24454002)(479174004)(83506001)(87936001)(76176999)(54356999)(65816999)(97736003)(50466002)(64126003)(92566002)(50986999)(19580395003)(19580405001)(33656002)(62966003)(101416001)(46102003)(106466001)(110136001)(23746002)(105586002)(36756003)(93886004)(59896002)(77156002)(2950100001)(68736005)(77096005)(80316001)(64706001)(47776003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR0201MB1008;H:atltwp02.amd.com;FPR:;SPF:None;MLV:sfv;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-DmarcAction-Test: None X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(3005003);SRVR:DM2PR0201MB1008; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004);SRVR:DM2PR0201MB1008; X-Forefront-PRVS: 045315E1EE X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:DM2PR0201MB1008; X-OriginatorOrg: amd4.onmicrosoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jan 2015 11:58:06.1478 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0201MB1008 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/07/2015 12:58 AM, Rusty Russell wrote: > Kees Cook writes: >> On Sun, Jan 4, 2015 at 8:28 PM, Rusty Russell wrote: >>> Kees, as far as I can tell you need another 0-terminated vmlinux.relocs >>> section for weak symbols. These should not be relocated if already 0. >> >> A few questions: >> >> Why doesn't this break on 32-bit without kASLR? 32-bit does relocation >> by default, even without CONFIG_RANDOMIZE_BASE. > > Well, the offset was 0 until I removed CONFIG_HIBERNATE. > >> Are there any symbols that are NULL that aren't weak? I'd expect all >> strong symbols to have non-zero offsets, but I must be >> misunderstanding something here. > > I don't think there would be. Anyway, you might be able to filter them > out in x86/tools/relocs itself. > > Cheers, > Rusty. > Hi Kees, Did you had time to look at the problem ? Oded