Re: [PATCH 2/3] MIPS: qi_lb60: Register watchdog device

[Guenter Roeck <linux@roeck-us.net>]

On 01/10/2015 05:37 PM, Maarten ter Huurne wrote:
> On Saturday 10 January 2015 17:24:53 Guenter Roeck wrote:
>> On 01/10/2015 10:29 AM, Lars-Peter Clausen wrote:
>>> The next commit will move the restart code to the watchdog driver. So
>>> for
>>> restart to continue to work we need to register the watchdog device.
>>>
>>> Also enable the watchdog driver in the default config.
>>>
>>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>>> ---
>>>
>>>    arch/mips/configs/qi_lb60_defconfig |    2 ++
>>>    arch/mips/jz4740/board-qi_lb60.c    |    1 +
>>>    2 files changed, 3 insertions(+)
>>>
>>> diff --git a/arch/mips/configs/qi_lb60_defconfig
>>> b/arch/mips/configs/qi_lb60_defconfig index 2b96547..ce06a92 100644
>>> --- a/arch/mips/configs/qi_lb60_defconfig
>>> +++ b/arch/mips/configs/qi_lb60_defconfig
>>> @@ -73,6 +73,8 @@ CONFIG_POWER_SUPPLY=y
>>>
>>>    CONFIG_BATTERY_JZ4740=y
>>>    CONFIG_CHARGER_GPIO=y
>>>    # CONFIG_HWMON is not set
>>>
>>> +CONFIG_WATCHDOG=y
>>> +CONFIG_JZ4740_WDT=y
>>
>> Shouldn't JZ4740_WDT be selected from MACH_JZ4740 ?
>>
>> Guess it doesn't really matter if there is just one board, but if there
>> is ever another board the reset handler would not automatically be
>> enabled.
>
> There is only one board in the mainline kernel, but Paul Cercueil and me did
> maintain a kernel for the Dingoo A320 for a while which is also JZ4740-
> based. Also, a lot of the JZ4740 drivers can be used as-is or with small
> adaptations on later SoC generations. For example, we're using a slightly
> modified version of this watchdog driver on the JZ4770-based GCW Zero.
>

Where does that leave us ? Should CONFIG_JZ4740_WDT be auto-selected ?

Thanks,
Guenter