All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerlando Falauto <gerlando.falauto@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd_sf: Fix problem with "sf update" and unaligned length
Date: Mon, 12 Jan 2015 09:12:17 +0100	[thread overview]
Message-ID: <54B381E1.6040803@keymile.com> (raw)
In-Reply-To: <54B37E28.9000705@denx.de>

Hi Stefan,

On 01/12/2015 08:56 AM, Stefan Roese wrote:
> Hi Gerlando,
>
> On 12.01.2015 08:51, Gerlando Falauto wrote:
>> thanks for the patch.
>> Please compare it with my v1 revision of the patch:
>> http://patchwork.ozlabs.org/patch/150468/
>> Back then, Simon suggested to use two separate SPI flash operations to
>> avoid the memcpy() operation.
>
> This again could generate unaligned accesses which my patch version does
> not do.

That's right -- I was just trying to say that my v1 was actually doing 
the same thing as yours, and to explain why I changed it at a later 
point (which seemed legitimate back then). Since my new revision 
introduced unaligned accesses, we're now essentially reverting to the 
original one. That's all.

Thank you!
Gerlando

>
>> I guess noone would have guessed about
>> QSPI devices at the time.
>>
>> Anyway, your patch looks even better than my v1 then, so:
>>
>> Acked-by: Gerlando Falauto <gerlando.falauto@keymile.com>
>
> Thanks,
> Stefan
>

      reply	other threads:[~2015-01-12  8:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-09 13:39 [U-Boot] [PATCH] cmd_sf: Fix problem with "sf update" and unaligned length Stefan Roese
2015-01-12  7:17 ` Wolfgang Denk
2015-01-12  7:27   ` Stefan Roese
2015-01-12  8:07     ` Gerlando Falauto
2015-01-12 21:12       ` Wolfgang Denk
2015-01-12 21:10     ` Wolfgang Denk
2015-01-13  6:05       ` Stefan Roese
2015-04-22 11:11         ` Jagan Teki
2015-04-22 11:15           ` Stefan Roese
2015-04-22 11:26             ` Jagan Teki
2015-01-12  7:51 ` Gerlando Falauto
2015-01-12  7:56   ` Stefan Roese
2015-01-12  8:12     ` Gerlando Falauto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B381E1.6040803@keymile.com \
    --to=gerlando.falauto@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.