From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1YAagl-00045k-M1 for mharc-qemu-trivial@gnu.org; Mon, 12 Jan 2015 03:49:31 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAagg-0003wr-3z for qemu-trivial@nongnu.org; Mon, 12 Jan 2015 03:49:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAagf-00066Z-8r for qemu-trivial@nongnu.org; Mon, 12 Jan 2015 03:49:26 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:34673) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAaga-00061A-Lk; Mon, 12 Jan 2015 03:49:20 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 3C21B406C6; Mon, 12 Jan 2015 11:49:10 +0300 (MSK) Message-ID: <54B38A86.7030902@msgid.tls.msk.ru> Date: Mon, 12 Jan 2015 11:49:10 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.3.0 MIME-Version: 1.0 To: Paolo Bonzini , qemu-devel@nongnu.org References: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> OpenPGP: id=804465C5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, zhang.zhanghailiang@huawei.com, peter.huangpeng@huawei.com Subject: Re: [Qemu-trivial] [PATCH] vt82c686: avoid out-of-bounds read X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Jan 2015 08:49:30 -0000 10.12.2014 12:17, Paolo Bonzini wrote: > superio_ioport_readb can read the 256th element of the array. > Coverity reports an out-of-bounds write in superio_ioport_writeb, > but it does not show the corresponding out-of-bounds read > because it cannot prove that it can happen. Fix the root > cause of the problem (zhanghailang's patch instead fixes > the logic in superio_ioport_writeb). (Finally) applied to -trivial, thanks! /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAage-0003vG-DI for qemu-devel@nongnu.org; Mon, 12 Jan 2015 03:49:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAaga-000650-T4 for qemu-devel@nongnu.org; Mon, 12 Jan 2015 03:49:24 -0500 Message-ID: <54B38A86.7030902@msgid.tls.msk.ru> Date: Mon, 12 Jan 2015 11:49:10 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1418203056-5365-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] vt82c686: avoid out-of-bounds read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, zhang.zhanghailiang@huawei.com, peter.huangpeng@huawei.com 10.12.2014 12:17, Paolo Bonzini wrote: > superio_ioport_readb can read the 256th element of the array. > Coverity reports an out-of-bounds write in superio_ioport_writeb, > but it does not show the corresponding out-of-bounds read > because it cannot prove that it can happen. Fix the root > cause of the problem (zhanghailang's patch instead fixes > the logic in superio_ioport_writeb). (Finally) applied to -trivial, thanks! /mjt