All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Akinobu Mita <akinobu.mita@gmail.com>, linux-scsi@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Christoph Hellwig <hch@lst.de>,
	"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [PATCH v3 4/4] scsi: esp_scsi: adjust module reference for scsi host
Date: Mon, 12 Jan 2015 10:18:51 +0100	[thread overview]
Message-ID: <54B3917B.7010406@suse.de> (raw)
In-Reply-To: <1420984206-22341-5-git-send-email-akinobu.mita@gmail.com>

On 01/11/2015 02:50 PM, Akinobu Mita wrote:
> While accessing a scsi device on host adapter supported by sub driver for
> the ESP chip (mac_esp, am53c974, sun_esp, jazz_esp, sun3x_esp), the module
> reference count is not incremented.  Because these drivers allocate scsi
> hosts with scsi_esp_template defined in ESP SCSI driver core module.  So
> these drivers always can be unloaded.
> 
> This fixes it by passing correct module reference to newly introduced
> scsi_esp_host_alloc() so that .module field in struct Scsi_Host can be
> adjusted.
> 
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
> Cc: linux-scsi@vger.kernel.org
> ---
> New patch from v3
> 
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		               zSeries & Storage
hare@suse.de			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-01-12  9:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-11 13:50 [PATCH v3 0/4] scsi: ufs & ums-* & esp_scsi: fix module reference counting Akinobu Mita
     [not found] ` <1420984206-22341-1-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-11 13:50   ` [PATCH v3 1/4] scsi: add ability to adjust module reference for scsi host Akinobu Mita
     [not found]     ` <1420984206-22341-2-git-send-email-akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-01-12  9:17       ` Hannes Reinecke
2015-01-11 13:50 ` [PATCH v3 2/4] scsi: ufs: " Akinobu Mita
2015-01-11 13:50 ` [PATCH v3 3/4] usb: storage: " Akinobu Mita
2015-01-11 13:50 ` [PATCH v3 4/4] scsi: esp_scsi: " Akinobu Mita
2015-01-11 17:55   ` David Miller
2015-01-12  9:18   ` Hannes Reinecke [this message]
2015-01-12  9:36 ` [PATCH v3 0/4] scsi: ufs & ums-* & esp_scsi: fix module reference counting Christoph Hellwig
     [not found]   ` <20150112093610.GA25942-jcswGhMUV9g@public.gmane.org>
2015-01-13 13:57     ` Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B3917B.7010406@suse.de \
    --to=hare@suse.de \
    --cc=JBottomley@parallels.com \
    --cc=akinobu.mita@gmail.com \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.