From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] xen/evtchn: Alter free_xen_event_channel() to take a domain rather than vcpu Date: Mon, 12 Jan 2015 10:10:46 +0000 Message-ID: <54B39DA6.7020508@citrix.com> References: <1421056003-18872-1-git-send-email-andrew.cooper3@citrix.com> <54B3AAD50200007800053914@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54B3AAD50200007800053914@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Keir Fraser , Xen-devel List-Id: xen-devel@lists.xenproject.org On 12/01/15 10:07, Jan Beulich wrote: >>>> On 12.01.15 at 10:46, wrote: >> The resource behind an event channel is domain centric rather than vcpu >> centric, and free_xen_event_channel() only follows the vcpu's domain >> pointer. > I wonder whether for symmetry alloc_unbound_xen_event_channel() > shouldn't then also take a [struct domain *, unsigned int vcpu_id] > pair instead of a struct vcpu *. Sounds like a good idea - I will do that for v2. ~Andrew