From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAe4Q-0004O8-Ld for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:26:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAe4J-00007o-U4 for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:26:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59577) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAe4J-00007b-NH for qemu-devel@nongnu.org; Mon, 12 Jan 2015 07:26:03 -0500 Message-ID: <54B3BD4E.30407@redhat.com> Date: Mon, 12 Jan 2015 13:25:50 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112115958.3504.62352.stgit@PASHA-ISP> <54B3BBC4.2080804@redhat.com> <001101d02e62$3c20ce40$b4626ac0$@Dovgaluk@ispras.ru> In-Reply-To: <001101d02e62$3c20ce40$b4626ac0$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v7 02/21] replay: global variables and function stubs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 12/01/2015 13:21, Pavel Dovgaluk wrote: >>> > > +{ 'enum': 'ReplaySubmode', >>> > > + 'data': [ 'unknown', 'normal' ] } >> > >> > What is a submode? Can you just check if replay_file is NULL? > Submode is not very useful for these core patches. > More submodes will be introduces in reverse debugging patches. I see. For now, can you replace it with just a replay_file check, and move this definition to the reverse debugging patches? Paolo