From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91: board-dt-sama5: add phy_fixup to override NAND_Tree which improperly strapp-in during the reset period.
Date: Mon, 12 Jan 2015 15:52:26 +0100 [thread overview]
Message-ID: <54B3DFAA.9020804@atmel.com> (raw)
In-Reply-To: <1418283069-5648-1-git-send-email-wenyou.yang@atmel.com>
Le 11/12/2014 08:31, Wenyou Yang a ?crit :
> Appearance: On some SAMA5D4EK boards, after power up, the Eth1 doesn't work.
>
> Reason: The PIOE2 pin is connected to the NAND_Tree# of KSZ8081,
> But it outputs LOW during the reset period, which cause the NAND_Tree# enabled.
>
> Add phy_fixup() to disable NAND_Tree by overriding the Operation
> Mode Strap Override register(i.e. Register 16h) to clear the NAND_Tree bit.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Stacked on top of at91-3.19-fixes.
Bye,
> ---
> arch/arm/mach-at91/board-dt-sama5.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/mach-at91/board-dt-sama5.c b/arch/arm/mach-at91/board-dt-sama5.c
> index 8fb9ef5..97f7367 100644
> --- a/arch/arm/mach-at91/board-dt-sama5.c
> +++ b/arch/arm/mach-at91/board-dt-sama5.c
> @@ -17,6 +17,7 @@
> #include <linux/of_platform.h>
> #include <linux/phy.h>
> #include <linux/clk-provider.h>
> +#include <linux/phy.h>
>
> #include <asm/setup.h>
> #include <asm/irq.h>
> @@ -26,8 +27,25 @@
>
> #include "generic.h"
>
> +static int ksz8081_phy_fixup(struct phy_device *phy)
> +{
> + int value;
> +
> + value = phy_read(phy, 0x16);
> + value &= ~0x20;
> + phy_write(phy, 0x16, value);
> +
> + return 0;
> +}
> +
> static void __init sama5_dt_device_init(void)
> {
> + if (of_machine_is_compatible("atmel,sama5d4ek") &&
> + IS_ENABLED(CONFIG_PHYLIB)) {
> + phy_register_fixup_for_id("fc028000.etherne:00",
> + ksz8081_phy_fixup);
> + }
> +
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> }
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Wenyou Yang <wenyou.yang@atmel.com>
Cc: <linux@arm.linux.org.uk>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: at91: board-dt-sama5: add phy_fixup to override NAND_Tree which improperly strapp-in during the reset period.
Date: Mon, 12 Jan 2015 15:52:26 +0100 [thread overview]
Message-ID: <54B3DFAA.9020804@atmel.com> (raw)
In-Reply-To: <1418283069-5648-1-git-send-email-wenyou.yang@atmel.com>
Le 11/12/2014 08:31, Wenyou Yang a écrit :
> Appearance: On some SAMA5D4EK boards, after power up, the Eth1 doesn't work.
>
> Reason: The PIOE2 pin is connected to the NAND_Tree# of KSZ8081,
> But it outputs LOW during the reset period, which cause the NAND_Tree# enabled.
>
> Add phy_fixup() to disable NAND_Tree by overriding the Operation
> Mode Strap Override register(i.e. Register 16h) to clear the NAND_Tree bit.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
Stacked on top of at91-3.19-fixes.
Bye,
> ---
> arch/arm/mach-at91/board-dt-sama5.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm/mach-at91/board-dt-sama5.c b/arch/arm/mach-at91/board-dt-sama5.c
> index 8fb9ef5..97f7367 100644
> --- a/arch/arm/mach-at91/board-dt-sama5.c
> +++ b/arch/arm/mach-at91/board-dt-sama5.c
> @@ -17,6 +17,7 @@
> #include <linux/of_platform.h>
> #include <linux/phy.h>
> #include <linux/clk-provider.h>
> +#include <linux/phy.h>
>
> #include <asm/setup.h>
> #include <asm/irq.h>
> @@ -26,8 +27,25 @@
>
> #include "generic.h"
>
> +static int ksz8081_phy_fixup(struct phy_device *phy)
> +{
> + int value;
> +
> + value = phy_read(phy, 0x16);
> + value &= ~0x20;
> + phy_write(phy, 0x16, value);
> +
> + return 0;
> +}
> +
> static void __init sama5_dt_device_init(void)
> {
> + if (of_machine_is_compatible("atmel,sama5d4ek") &&
> + IS_ENABLED(CONFIG_PHYLIB)) {
> + phy_register_fixup_for_id("fc028000.etherne:00",
> + ksz8081_phy_fixup);
> + }
> +
> of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> }
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2015-01-12 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-11 7:31 [PATCH] ARM: at91: board-dt-sama5: add phy_fixup to override NAND_Tree which improperly strapp-in during the reset period Wenyou Yang
2014-12-11 7:31 ` Wenyou Yang
2014-12-16 10:20 ` Nicolas Ferre
2014-12-16 10:20 ` Nicolas Ferre
2014-12-16 19:10 ` Florian Fainelli
2014-12-16 19:10 ` Florian Fainelli
2014-12-17 1:21 ` Yang, Wenyou
2014-12-17 1:21 ` Yang, Wenyou
2015-01-12 14:52 ` Nicolas Ferre [this message]
2015-01-12 14:52 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B3DFAA.9020804@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.