From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v2] libxl: Don't ignore error when we fail to give access to ioport/irq/iomem Date: Mon, 12 Jan 2015 16:36:24 +0000 Message-ID: <54B3F808.1040305@linaro.org> References: <1420819005-6222-1-git-send-email-julien.grall@linaro.org> <20150109160608.GC4226@zion.uk.xensource.com> <1421080519.28606.5.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YAhz5-0000kE-2y for xen-devel@lists.xenproject.org; Mon, 12 Jan 2015 16:36:55 +0000 Received: by mail-wi0-f169.google.com with SMTP id r20so15017761wiv.0 for ; Mon, 12 Jan 2015 08:36:53 -0800 (PST) In-Reply-To: <1421080519.28606.5.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Wei Liu Cc: xen-devel@lists.xenproject.org, Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org Hi Ian, On 12/01/15 16:35, Ian Campbell wrote: > On Fri, 2015-01-09 at 16:06 +0000, Wei Liu wrote: >> On Fri, Jan 09, 2015 at 03:56:45PM +0000, Julien Grall wrote: >>> If we fail to give the access, the domain will unlikely work correctly. >>> So we should bail out at the first error. >>> >>> Signed-off-by: Julien Grall >>> Cc: Ian Jackson >>> Cc: Stefano Stabellini >>> Cc: Ian Campbell >> >> Acked-by: Wei Liu > > Applied, thanks. > > Should this be backported? Yes. But it may not apply directly on Xen 4.4. Regards, -- Julien Grall