From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: ath10k <ath10k@lists.infradead.org>
Subject: Re: Question on CE_DESC_FLAGS_META_DATA field.
Date: Mon, 12 Jan 2015 08:53:22 -0800 [thread overview]
Message-ID: <54B3FC02.9020404@candelatech.com> (raw)
In-Reply-To: <CA+BoTQkAb+sn4nSZ+E=w1yp_fHK=5HuLs-mtjvJ3ZC6WFX9iFw@mail.gmail.com>
On 01/11/2015 11:42 PM, Michal Kazior wrote:
> On 9 January 2015 at 19:06, Ben Greear <greearb@candelatech.com> wrote:
>> While poking in the CE code, I notice this below.
>>
>> Shouldn't the CE_DESC_FLAGS_META_DATA_LSB be 2, and if not,
>> can someone explain why?
>>
>> [greearb@ben-dt2 ath10k]$ grep CE_DESC_FLAGS_META_DATA *h
>> ce.h:#define CE_DESC_FLAGS_META_DATA_MASK 0xFFFC
>> ce.h:#define CE_DESC_FLAGS_META_DATA_LSB 3
>
> Nice catch!
>
> This shouldn't have been harmful though. Meta data part is used to
> store htc endpoint ids which shouldn't overflow the mask even with
> lsb=3 and as far as I know neither CE nor firmware cares what is
> stored there.
Ok, I'll fix this in my tree and post a patch sometime soon.
Upstream 10.1 firmware does ignore the transfer_id, but I am
fixing that in my firmware to aid debugging (and fixing ath10k
driver to use it for debugging as well).
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
prev parent reply other threads:[~2015-01-12 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 18:06 Question on CE_DESC_FLAGS_META_DATA field Ben Greear
2015-01-12 7:42 ` Michal Kazior
2015-01-12 16:53 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B3FC02.9020404@candelatech.com \
--to=greearb@candelatech.com \
--cc=ath10k@lists.infradead.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.