From: Stephen Smalley <sds@tycho.nsa.gov>
To: John Brooks <john.brooks@jolla.com>, selinux@tycho.nsa.gov
Subject: Re: [PATCH 1/3] Build libsepol with -O2
Date: Mon, 12 Jan 2015 12:01:25 -0500 [thread overview]
Message-ID: <54B3FDE5.8000802@tycho.nsa.gov> (raw)
In-Reply-To: <1420668221-52637-2-git-send-email-john.brooks@jolla.com>
On 01/07/2015 05:03 PM, John Brooks wrote:
> libsepol contains performance sensitive code; in particular, compiler
> optimizations save a few minutes off of the optimized policydb hash
> tables.
> ---
> libsepol/src/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libsepol/src/Makefile b/libsepol/src/Makefile
> index 6450d67..059f198 100644
> --- a/libsepol/src/Makefile
> +++ b/libsepol/src/Makefile
> @@ -22,7 +22,7 @@ OBJS= $(patsubst %.c,%.o,$(wildcard *.c))
> LOBJS= $(patsubst %.c,%.lo,$(wildcard *.c))
> CFLAGS ?= -Werror -Wall -W -Wundef -Wshadow -Wmissing-format-attribute
>
> -override CFLAGS += -I. -I../include -D_GNU_SOURCE
> +override CFLAGS += -I. -I../include -D_GNU_SOURCE -O2
>
> ifneq ($(DISABLE_CIL),y)
> OBJS += $(sort $(patsubst %.c,%.o,$(wildcard $(CILDIR)/src/*.c) $(CIL_GENERATED)))
>
Not sure we want this to always be set even if the caller specified
their own set of CFLAGS on the make command-line.
next prev parent reply other threads:[~2015-01-12 17:01 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 22:03 [PATCH 0/3] Improve check_assertions performance through hash tweaks John Brooks
2015-01-07 22:03 ` [PATCH 1/3] Build libsepol with -O2 John Brooks
2015-01-12 17:01 ` Stephen Smalley [this message]
2015-01-07 22:03 ` [PATCH 2/3] Use a better hash function for libsepol's avtab John Brooks
2015-01-12 17:30 ` Stephen Smalley
2015-01-13 1:38 ` John Brooks
2015-01-13 13:53 ` Stephen Smalley
2015-01-07 22:03 ` [PATCH 3/3] Tweak avtab hash table parameters for better performance John Brooks
2015-01-12 17:47 ` Stephen Smalley
2015-01-12 17:55 ` Stephen Smalley
2015-01-12 20:07 ` Stephen Smalley
2015-01-13 1:25 ` John Brooks
2015-01-13 13:50 ` Stephen Smalley
2015-01-13 14:00 ` Stephen Smalley
2015-01-15 0:24 ` [PATCH v2 0/3] Improve check_assertions performance through hash tweaks John Brooks
2015-01-15 0:24 ` [PATCH v2 1/3] Build libsepol with -O2 John Brooks
2015-01-15 0:24 ` [PATCH v2 2/3] Use a better hash function for libsepol's avtab John Brooks
2015-01-15 0:24 ` [PATCH v2 3/3] Tweak avtab hash table parameters for better performance John Brooks
2015-01-15 18:56 ` [PATCH v2 0/3] Improve check_assertions performance through hash tweaks Stephen Smalley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B3FDE5.8000802@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=john.brooks@jolla.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.