Re: [PATCH net-next v3 3/3] bridge: new function to pack vlans into ranges during gets

[roopa <roopa@cumulusnetworks.com>]

On 1/12/15, 3:47 PM, Thomas Graf wrote:
> On 01/10/15 at 07:31am, roopa@cumulusnetworks.com wrote:
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> This patch adds new function to pack vlans into ranges
>> whereever applicable using the flags BRIDGE_VLAN_INFO_RANGE_BEGIN
>> and BRIDGE VLAN_INFO_RANGE_END
>>
>> Old vlan packing code is moved to a new function and continues to be
>> called when filter_mask is RTEXT_FILTER_BRVLAN.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> Roopa,
>
> Just came across these new warnings:
>
> net/bridge/br_netlink.c: In function ‘br_fill_ifinfo’:
> net/bridge/br_netlink.c:146:32: warning: ‘vid_range_flags’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>    err = br_fill_ifvlaninfo_range(skb, vid_range_start,
>                                  ^
> net/bridge/br_netlink.c:108:6: note: ‘vid_range_flags’ was declared here
>    u16 vid_range_flags;
sorry abt that, patch coming...in a few mins. compiling...
Don't remember seeing it during my compilation...

Thanks!