From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [PATCH] drm/nouveau/nouveau_bo: Remove unused function Date: Tue, 13 Jan 2015 11:01:10 +0900 Message-ID: <54B47C66.1010805@nvidia.com> References: <1421015495-24744-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B4D06E404 for ; Mon, 12 Jan 2015 18:01:42 -0800 (PST) In-Reply-To: <1421015495-24744-1-git-send-email-rickard_strandqvist@spectrumdigital.se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rickard Strandqvist , David Airlie , Ben Skeggs Cc: Alex Deucher , =?windows-1252?Q?Christian_K=F6nig?= , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gMDEvMTIvMjAxNSAwNzozMSBBTSwgUmlja2FyZCBTdHJhbmRxdmlzdCB3cm90ZToKPiBSZW1v dmUgdGhlIGZ1bmN0aW9uIG5vdXZlYXVfYm9fcmQxNigpIHRoYXQgaXMgbm90IHVzZWQgYW55d2hl cmUuCj4KPiBUaGlzIHdhcyBwYXJ0aWFsbHkgZm91bmQgYnkgdXNpbmcgYSBzdGF0aWMgY29kZSBh bmFseXNpcyBwcm9ncmFtIGNhbGxlZCBjcHBjaGVjay4KCm5vdXZlYXVfYm9fd3IxNigpIGJlaW5n IHByZXN1bWFibHkgdXNlZCAoc2luY2UgaXQgaXMgbm90IHJlbW92ZWQgYnkgdGhpcyAKcGF0Y2gp LCBpdCBzb3VuZHMgc2FmZSB0byBrZWVwIGl0cyByZWFkIGNvdW50ZXJwYXJ0PwoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753001AbbAMCBm (ORCPT ); Mon, 12 Jan 2015 21:01:42 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:1617 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbbAMCBl (ORCPT ); Mon, 12 Jan 2015 21:01:41 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Mon, 12 Jan 2015 18:00:20 -0800 Message-ID: <54B47C66.1010805@nvidia.com> Date: Tue, 13 Jan 2015 11:01:10 +0900 From: Alexandre Courbot Organization: NVIDIA User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Rickard Strandqvist , David Airlie , Ben Skeggs CC: Maarten Lankhorst , Alex Deucher , =?windows-1252?Q?Christian_K=F6nig?= , , Subject: Re: [PATCH] drm/nouveau/nouveau_bo: Remove unused function References: <1421015495-24744-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1421015495-24744-1-git-send-email-rickard_strandqvist@spectrumdigital.se> X-NVConfidentiality: public X-Originating-IP: [10.19.57.128] X-ClientProxiedBy: HKMAIL103.nvidia.com (10.18.16.12) To HKMAIL102.nvidia.com (10.18.16.11) Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2015 07:31 AM, Rickard Strandqvist wrote: > Remove the function nouveau_bo_rd16() that is not used anywhere. > > This was partially found by using a static code analysis program called cppcheck. nouveau_bo_wr16() being presumably used (since it is not removed by this patch), it sounds safe to keep its read counterpart?