All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: exynos: clock: remove	clock_get_periph_rate()
Date: Tue, 13 Jan 2015 13:30:14 +0900	[thread overview]
Message-ID: <54B49F56.8040202@samsung.com> (raw)
In-Reply-To: <CAPnjgZ1+ptzbuxcZynP=F-4yScPnh_S3xVvCAJmN1mggof-GfQ@mail.gmail.com>

Hi,

On 01/13/2015 01:16 PM, Simon Glass wrote:
> Hi,
> 
> On 7 January 2015 at 23:33, Jaehoon Chung <jh80.chung@samsung.com> wrote:
>> This api is wrong array bounds.
>>
>> arch/arm/cpu/armv7/exynos/clock.c: In function 'clock_get_periph_rate':
>> arch/arm/cpu/armv7/exynos/clock.c:265:47: warning: array subscript is above array bounds [-Warray-bounds]
>>   struct clk_bit_info *bit_info = &clk_bit_info[peripheral];
>>
>> And it doesn't use anywhere. It only used to get pwm clock.
>> So it changes from clock_get_periph_rate() to get_pwm_clock.
>>
>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>> ---
>>  arch/arm/cpu/armv7/exynos/clock.c      | 173 +++++----------------------------
>>  arch/arm/include/asm/arch-exynos/clk.h |   9 --
>>  2 files changed, 25 insertions(+), 157 deletions(-)
> 
> As discussed on the other patch, can we fix this and use it, rather
> than removing it? Lots of little functions for each n peripherals and
> each m SoCs = n * m functions and a primitive API.
> 
> This was a request made as part of the Snow and Pit developments, but
> it didn't get very far. Can we finish it?
> 

Who does follow up it? It's best solution if it's finished soon but if
it takes long time, i think it is better to remove now.

Thanks.

      reply	other threads:[~2015-01-13  4:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08  7:33 [U-Boot] [PATCH] ARM: exynos: clock: remove clock_get_periph_rate() Jaehoon Chung
2015-01-13  4:16 ` Simon Glass
2015-01-13  4:30   ` Joonyoung Shim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B49F56.8040202@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.