From mboxrd@z Thu Jan 1 00:00:00 1970 From: Philipp Hahn Subject: Re: Backport request for "tools/hotplug: set mtu from bridge for tap interface" - for Xen 4.4, 4.5, and unstable Date: Tue, 13 Jan 2015 08:15:52 +0100 Message-ID: <54B4C628.2030302@univention.de> References: <5464827B0200007800047188@mail.emea.novell.com> <20141118180343.GA12891@router-fw-old.local.net-space.pl> <21611.36575.47438.496721@mariner.uk.xensource.com> <20141119083535.GA321@router-fw-old.local.net-space.pl> <21683.60380.814254.885459@mariner.uk.xensource.com> <54B395EC02000091000E9EBE@prv-mh.provo.novell.com> <21683.65102.700004.973125@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <21683.65102.700004.973125@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Hello, On 12.01.2015 18:03, Ian Jackson wrote: > Charles Arnold writes ("Re: Backport request for "tools/hotplug: set mtu = from bridge for tap interface" - for Xen 4.4, 4.5, and unstable"): >> Add quotes around $bridge and $dev to handle spaces in names. >> This should go into 4.4, 4.5 and unstable. > = > Is this really necessary for backporting ? > = > Frankly I think if you put spaces in your network device names an > awful lot of things are going to break. Luckily for you at least Linux does not allow space characters in interface names: net/core/dev.c:936 dev_valid_name On the other hand I find not caring about quoting somehow dangerous, as I already expeienced one desaster caused by missing quotes. Just my 2=A2. Philipp