From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAxxW-0007xw-Vx for qemu-devel@nongnu.org; Tue, 13 Jan 2015 04:40:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAxxQ-0001sE-O3 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 04:40:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAxxQ-0001ry-Hm for qemu-devel@nongnu.org; Tue, 13 Jan 2015 04:40:16 -0500 Message-ID: <54B4E7F2.1040200@redhat.com> Date: Tue, 13 Jan 2015 10:40:02 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150112115944.3504.66763.stgit@PASHA-ISP> <20150112120111.3504.51955.stgit@PASHA-ISP> <54B3BA70.3080408@redhat.com> <000401d02f11$88a9c000$99fd4000$@Dovgaluk@ispras.ru> In-Reply-To: <000401d02f11$88a9c000$99fd4000$@Dovgaluk@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgaluk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com On 13/01/2015 10:15, Pavel Dovgaluk wrote: > The numbers have no meaning. They just have to be distinct in different places. This is easier to achieve if you give a name to each place. > Sorry, missed one thing. > run_all is used to distinguish timers processed in AIO by calling of timerlistgroup_run_timers function > and in main loop by calling qemu_clock_run_all_timers. Should you instead distinguish which TimerListGroup is being run? Then main loop would checkpoint once for every TimerListGroup (which means twice). > We need to distinguish that to secure the sequence of the events. > It makes sense when we use checkpointing while recording the execution. I see. Paolo