From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1YB0t3-000409-3y
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 07:48:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1YB0sw-0003XF-As
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 07:47:56 -0500
Received: from v220110690675601.yourvserver.net ([37.221.199.173]:58640)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1YB0sw-0003Wx-36
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 07:47:50 -0500
Message-ID: <54B513E7.90704@weilnetz.de>
Date: Tue, 13 Jan 2015 13:47:35 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1421126324-2036-1-git-send-email-rudy.zhangmin@huawei.com>
	<87iogb10n4.fsf@blackfin.pond.sub.org>
In-Reply-To: <87iogb10n4.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vl.c: optimized code format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, Zhang Min <rudy.zhangmin@huawei.com>
Cc: lizhengui@huawei.com, fangyi.fangyi@huawei.com, hz.wangzhiwei@huawei.com, subo7@huawei.com, kathy.wangting@huawei.com, qemu-devel@nongnu.org, wu.wubin@huawei.com, boby.chen@huawei.com, wangjie88@huawei.com, pbonzini@redhat.com, shiweixian@huawei.com, aliguori@amazon.com

Am 13.01.2015 um 10:38 schrieb Markus Armbruster:
> Zhang Min <rudy.zhangmin@huawei.com> writes:
>
>> From: Rudy Zhang <rudy.zhangmin@huawei.com>
>>
>> There are several tab characters in the 'vl.c' file. It leads to
>> to misalignment of the code. So, let the space instead of the tab.
>>
>> Signed-off-by: Rudy Zhang <rudy.zhangmin@huawei.com>
> While we don't want tabs in new code, we generally leave existing ones
> alone until we need to touch the line anyway, or the tabs get in the way
> somehow.

True. In this special case, there is already a similar patch queued for 
qemu-trivial, so Zhang Min's patch is not needed. As far as I know, that 
previous patch was sent to prepare further modifications in vl.c, that's 
why I acked it.

Stefan