Re: [PATCH v4] can/peak_usb: add support for PEAK new CANFD USB adapters

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1633 bytes --]

On 01/13/2015 02:29 PM, Marc Kleine-Budde wrote:
> On 01/13/2015 02:18 PM, Stephane Grosjean wrote:
>> Hi Marc,
>>
>> Le 07/01/2015 18:03, Marc Kleine-Budde a écrit :
>>> On 01/06/2015 11:00 AM, Stephane Grosjean wrote:
>>>   @@ -750,9 +795,10 @@ static int peak_usb_create_dev(struct
>>> peak_usb_adapter *peak_usb_adapter,
>>>       dev->can.clock = peak_usb_adapter->clock;
>>>       dev->can.bittiming_const = &peak_usb_adapter->bittiming_const;
>>>       dev->can.do_set_bittiming = peak_usb_set_bittiming;
>>> +    dev->can.data_bittiming_const =
>>> &peak_usb_adapter->data_bittiming_const;
>>> +    dev->can.do_set_data_bittiming = peak_usb_set_data_bittiming;
>>>       dev->can.do_set_mode = peak_usb_set_mode;
>>> -    dev->can.ctrlmode_supported = CAN_CTRLMODE_3_SAMPLES |
>>> -                      CAN_CTRLMODE_LISTENONLY;
>>> +    dev->can.ctrlmode_supported = peak_usb_adapter->ctrlmode_supported;
>>> All ctrlmode_supported can go into a seperate patch.
>>
>> I'll try but can you please explain why?

BTW: you can split a patch into multiple patches with git quite easy:

# move branch head one patch backwards, working copy stays unmodified:
git reset HEAD^

# for each hunk git will ask you if you want to stage it.
# you can even split a hunk.
git add -p

or use git gui instead of git add -p.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]