From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:37116)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@parallels.com>) id 1YB4ZN-0003dM-0L
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 11:43:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vsementsov@parallels.com>) id 1YB4ZI-00058G-Sz
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 11:43:52 -0500
Received: from mx2.parallels.com ([199.115.105.18]:33241)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vsementsov@parallels.com>) id 1YB4ZI-000583-NC
	for qemu-devel@nongnu.org; Tue, 13 Jan 2015 11:43:48 -0500
Message-ID: <54B54B38.6080800@parallels.com>
Date: Tue, 13 Jan 2015 19:43:36 +0300
From: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
MIME-Version: 1.0
References: <1419297142-24282-1-git-send-email-jsnow@redhat.com>	<1419297142-24282-7-git-send-email-jsnow@redhat.com>
	<54A2ACF7.2020302@parallels.com> <54B09BAF.9040909@redhat.com>
	<54B4EB71.7000807@parallels.com> <54B549B9.2060105@redhat.com>
In-Reply-To: <54B549B9.2060105@redhat.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v10 06/13] block: Add
 bdrv_copy_dirty_bitmap and bdrv_clear_dirty_bitmap
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, stefanha@redhat.com, mreitz@redhat.com

No, I'm saying about adding comment about using size in sectors and 
granularity in bytes in BdrvDirtyBitmap structure.

On 10.01.2015 06:25, John Snow wrote:
......
> What I will do instead is just to document this quirk. Look out for V11 

Best regards,
Vladimir

On 13.01.2015 19:37, John Snow wrote:
>
> On 01/13/2015 04:54 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Hmm, can't find it in v11
>>
>> Best regards,
>> Vladimir
>>
>
> I changed approach and instead of copying bitmaps to be used with the 
> incremental backup, I lock them in place. So copy isn't used anymore 
> in my set, so the name of the patch changed.
>
> --js