From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 14/21] ARM: imx6: convert GPC to stacked domains Date: Tue, 13 Jan 2015 18:36:17 +0000 Message-ID: <54B565A1.5010206@arm.com> References: <1421087187-26988-1-git-send-email-marc.zyngier@arm.com> <1421087187-26988-15-git-send-email-marc.zyngier@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Linus Walleij Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , Benoit Cousson , Tony Lindgren , Nishanth Menon , Santosh Shilimkar , Shawn Guo , Sascha Hauer , Kukjin Kim , Simon Horman , Magnus Damm , Michal Simek , Rob Herring , Mark Rutland , Jason Cooper , Thomas Gleixner , Stefan Agner , "linux-arm-kernel@lists.infradead.org" , linux-samsung-soc , Linux-OMAP List-Id: linux-omap@vger.kernel.org On 13/01/15 06:09, Linus Walleij wrote: Hi Linus, > On Mon, Jan 12, 2015 at 7:26 PM, Marc Zyngier wrote: > >> IMX6 has been (ab)using the gic_arch_extn to provide >> wakeup from suspend, and it makes a lot of sense to convert >> this code to use stacked domains instead. >> >> This patch does just this, updating the DT files to actually >> reflect what the HW provides. >> >> BIG FAT WARNING: because the DTs were so far lying by not >> exposing the fact that the GPC block is actually the first >> interrupt controller in the chain, kernels with this patch >> applied wont have any suspend-resume facility when booted >> with old DTs, and old kernels with updated DTs won't even boot. >> >> Tested-by: Stefan Agner >> Acked-by: Stefan Agner >> Signed-off-by: Marc Zyngier > > (...) > >> +static int imx_gpc_domain_alloc(struct irq_domain *domain, >> + unsigned int virq, > > Nutcase nitpick on this nice patch series: every time I see "virq" my > OCD triggers, as I think the "v" in "virq" stand for virtual. These irqs > are no more virtual than any other Linux irq numbers, hwirq is > more to the point. > > I just refer to these as "irq" (sans "v") in any code I write. That's fair enough. I'll update that as I fix some other nits. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Tue, 13 Jan 2015 18:36:17 +0000 Subject: [PATCH v3 14/21] ARM: imx6: convert GPC to stacked domains In-Reply-To: References: <1421087187-26988-1-git-send-email-marc.zyngier@arm.com> <1421087187-26988-15-git-send-email-marc.zyngier@arm.com> Message-ID: <54B565A1.5010206@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13/01/15 06:09, Linus Walleij wrote: Hi Linus, > On Mon, Jan 12, 2015 at 7:26 PM, Marc Zyngier wrote: > >> IMX6 has been (ab)using the gic_arch_extn to provide >> wakeup from suspend, and it makes a lot of sense to convert >> this code to use stacked domains instead. >> >> This patch does just this, updating the DT files to actually >> reflect what the HW provides. >> >> BIG FAT WARNING: because the DTs were so far lying by not >> exposing the fact that the GPC block is actually the first >> interrupt controller in the chain, kernels with this patch >> applied wont have any suspend-resume facility when booted >> with old DTs, and old kernels with updated DTs won't even boot. >> >> Tested-by: Stefan Agner >> Acked-by: Stefan Agner >> Signed-off-by: Marc Zyngier > > (...) > >> +static int imx_gpc_domain_alloc(struct irq_domain *domain, >> + unsigned int virq, > > Nutcase nitpick on this nice patch series: every time I see "virq" my > OCD triggers, as I think the "v" in "virq" stand for virtual. These irqs > are no more virtual than any other Linux irq numbers, hwirq is > more to the point. > > I just refer to these as "irq" (sans "v") in any code I write. That's fair enough. I'll update that as I fix some other nits. Thanks, M. -- Jazz is not dead. It just smells funny...