All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [iptables PATCH] configure: disable connlabel for static builds
Date: Tue, 13 Jan 2015 16:40:54 -0300	[thread overview]
Message-ID: <54B574C6.1040108@zacarias.com.ar> (raw)
In-Reply-To: <20150113193252.GH27216@breakpoint.cc>

On 01/13/2015 04:32 PM, Florian Westphal wrote:

> Gustavo Zacarias <gustavo@zacarias.com.ar> wrote:
>> Disable connlabel for purely static builds since it pulls in libdl which
>> isn't available in such cases causing build breakage.
> 
> What do you mean by 'purely static builds'?
> In any case, current iptables master
> 
> ./configure --disable-shared --enable-static && make
> 
> fails to build with your patch applied since configure thinks
> that neither libmnl nor libfntnl are present.
> 
> I also don't understand why connlabel should not be built with above
> configure options, care to elaborate?

See
http://autobuild.buildroot.net/results/b45/b45df862a5c7e0a45017d6be33a818c98489b663/
(build-end.log)

That's the precise build failure which is triggered when
libnetfilter_conntrack is around.
When it's not around (nfconntrack=0, from PKG_CHECK_MODULES) it won't
try to build it and the result is a proper purely-static build.
Hence i set it that way in the patch when the user explicitly says
--disable-shared.
Purely-static is a toolchain where there is no dlfcn.h and libdl, not
something you would see from (e)glibc but normal for uClibc.

I haven't tried on iptables master which adds nft functionality yet, but
this fixes it for 1.4.21.

Regards.

  reply	other threads:[~2015-01-13 19:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 13:46 [iptables PATCH] configure: disable connlabel for static builds Gustavo Zacarias
2015-01-13 19:32 ` Florian Westphal
2015-01-13 19:40   ` Gustavo Zacarias [this message]
2015-01-14  0:32     ` Jan Engelhardt
2015-01-14  9:48       ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B574C6.1040108@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.