From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Fam Zheng <famz@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread
Date: Tue, 13 Jan 2015 20:48:33 +0100 [thread overview]
Message-ID: <54B57691.4020007@redhat.com> (raw)
In-Reply-To: <CAFEAcA-W9-dVCGbqwgftPE3gk8p-_Gf2Qz2fOUHr+QXpfgxfvQ@mail.gmail.com>
On 13/01/2015 19:40, Peter Maydell wrote:
> On 13 January 2015 at 17:52, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> The block layer is now using __thread unconditionally.
>
> Where? I did a quick grep for __thread and (other than stuff in
> the *-user code and some Win32 specific files) there's no use of
> __thread outside the DEFINE_TLS wrappers.
It's in the pull request.
>> Remove the
>> "fake" TLS wrappers (that actually aren't TLS on !Linux) in
>> include/qemu/tls.h, and add a testcase.
>
> What platforms have you tested on? We definitely shouldn't
> widen our use of __thread without testing it on all the
> platforms we support...
Native TLS is supported by all platforms except Windows and, I think,
OpenBSD, which will have to use GCC's emulated TLS. For Windows we
already do. OpenBSD ports will have to use a new-enough GCC (basically
depend on the GPLv3 GCC port).
Paolo
next prev parent reply other threads:[~2015-01-13 19:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 17:52 [Qemu-devel] [PATCH 0/8] RCUification of the memory API, part 1 Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread Paolo Bonzini
2015-01-13 18:40 ` Peter Maydell
2015-01-13 19:48 ` Paolo Bonzini [this message]
2015-01-13 20:00 ` Peter Maydell
2015-01-13 20:27 ` Paolo Bonzini
2015-01-13 22:07 ` Peter Maydell
2015-04-28 21:04 ` Emilio G. Cota
2015-04-29 11:09 ` Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 2/8] rcu: add rcu library Paolo Bonzini
2015-01-15 10:39 ` Fam Zheng
2015-01-15 11:08 ` Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 3/8] rcu: add rcutorture Paolo Bonzini
2015-01-16 2:04 ` Fam Zheng
2015-01-16 11:22 ` Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 4/8] rcu: allow nesting of rcu_read_lock/rcu_read_unlock Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 5/8] rcu: add call_rcu Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 6/8] memory: remove assertion on memory_region_destroy Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 7/8] memory: protect current_map by RCU Paolo Bonzini
2015-01-13 17:52 ` [Qemu-devel] [PATCH 8/8] memory: avoid ref/unref in memory_region_find Paolo Bonzini
2015-01-16 13:04 ` [Qemu-devel] [PATCH 0/8] RCUification of the memory API, part 1 Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B57691.4020007@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.