From: Paolo Bonzini <pbonzini@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs
Date: Tue, 13 Jan 2015 20:49:59 +0100 [thread overview]
Message-ID: <54B576E7.6050203@redhat.com> (raw)
In-Reply-To: <20150113183734.GD31510@thinpad.lan.raisama.net>
On 13/01/2015 19:37, Eduardo Habkost wrote:
>> > + tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, XMM_Q(1));
>> > + tcg_gen_st_i64(cpu_tmp1_i64, cpu_env, d_offset + offsetof(XMMReg, XMM_Q(1));
> It looks good (I even sent my Reviewed-by line), but:
>
> target-i386/translate.c:2624:88: error: expected ‘)’ before ‘;’ token
> tcg_gen_ld_i64(cpu_tmp1_i64, cpu_env, s_offset + offsetof(XMMReg, XMM_Q(0));
> ^
This sounds familiar. I had attached the wrong version of the series,
but the only difference is the two extra parentheses.
Paolo
next prev parent reply other threads:[~2015-01-13 19:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 17:39 [Qemu-devel] [PATCH 0/3] target-i386: rework how AVX/AVX512 registers are stored Paolo Bonzini
2015-01-07 17:39 ` [Qemu-devel] [PATCH 1/4] target-i386: fix movntsd on big-endian hosts Paolo Bonzini
2015-01-13 16:50 ` Eduardo Habkost
2015-01-13 18:48 ` Eduardo Habkost
2015-01-13 19:49 ` Paolo Bonzini
2015-01-14 13:17 ` Eduardo Habkost
2015-01-14 13:24 ` Paolo Bonzini
2015-01-14 13:44 ` Eduardo Habkost
2015-01-07 17:39 ` [Qemu-devel] [PATCH 2/4] target-i386: do not memcpy in and out of xmm_regs Paolo Bonzini
2015-01-13 17:02 ` Eduardo Habkost
2015-01-13 18:37 ` Eduardo Habkost
2015-01-13 19:49 ` Paolo Bonzini [this message]
2015-01-07 17:39 ` [Qemu-devel] [PATCH 3/4] target-i386: use vmstate_offset_sub_array for AVX registers Paolo Bonzini
2015-01-07 17:39 ` [Qemu-devel] [PATCH 4/4] target-i386: make xmm_regs 512-bit wide Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B576E7.6050203@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.