From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB7oo-0007Rx-BR for qemu-devel@nongnu.org; Tue, 13 Jan 2015 15:12:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YB7ok-0006ts-Bk for qemu-devel@nongnu.org; Tue, 13 Jan 2015 15:12:02 -0500 Received: from fldsmtpe04.verizon.com ([140.108.26.143]:2076) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YB7ok-0006td-54 for qemu-devel@nongnu.org; Tue, 13 Jan 2015 15:11:58 -0500 From: Don Slutz Message-ID: <54B57C0B.9020105@terremark.com> Date: Tue, 13 Jan 2015 15:11:55 -0500 MIME-Version: 1.0 References: <1417612519-6931-1-git-send-email-dslutz@verizon.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, Don Slutz On 01/13/15 13:07, Stefano Stabellini wrote: > On Mon, 12 Jan 2015, Stefano Stabellini wrote: >> On Wed, 3 Dec 2014, Don Slutz wrote: >>> From: Stefano Stabellini >>> >>> Increase maxmem before calling xc_domain_populate_physmap_exact to >>> avoid the risk of running out of guest memory. This way we can also >>> avoid complex memory calculations in libxl at domain construction >>> time. >>> >>> This patch fixes an abort() when assigning more than 4 NICs to a VM. >>> >>> Signed-off-by: Stefano Stabellini >>> Signed-off-by: Don Slutz >>> --- >>> v2: Changes by Don Slutz >>> Switch from xc_domain_getinfo to xc_domain_getinfolist >>> Fix error check for xc_domain_getinfolist >>> Limit increase of maxmem to only do when needed: >>> Add QEMU_SPARE_PAGES (How many pages to leave free) >>> Add free_pages calculation >>> >>> xen-hvm.c | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/xen-hvm.c b/xen-hvm.c >>> index 7548794..d30e77e 100644 >>> --- a/xen-hvm.c >>> +++ b/xen-hvm.c >>> @@ -90,6 +90,7 @@ static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu) >>> #endif >>> >>> #define BUFFER_IO_MAX_DELAY 100 >>> +#define QEMU_SPARE_PAGES 16 >> >> We need a big comment here to explain why we have this parameter and >> when we'll be able to get rid of it. >> >> Other than that the patch is fine. >> >> Thanks! >> > > Actually I'll just go ahead and add the comment and commit, if for you > is OK. > That would be fine with me. I was still working on a good wording. -Don Slutz > Cheers, > > Stefano > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap Date: Tue, 13 Jan 2015 15:11:55 -0500 Message-ID: <54B57C0B.9020105@terremark.com> References: <1417612519-6931-1-git-send-email-dslutz@verizon.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org, Don Slutz List-Id: xen-devel@lists.xenproject.org On 01/13/15 13:07, Stefano Stabellini wrote: > On Mon, 12 Jan 2015, Stefano Stabellini wrote: >> On Wed, 3 Dec 2014, Don Slutz wrote: >>> From: Stefano Stabellini >>> >>> Increase maxmem before calling xc_domain_populate_physmap_exact to >>> avoid the risk of running out of guest memory. This way we can also >>> avoid complex memory calculations in libxl at domain construction >>> time. >>> >>> This patch fixes an abort() when assigning more than 4 NICs to a VM. >>> >>> Signed-off-by: Stefano Stabellini >>> Signed-off-by: Don Slutz >>> --- >>> v2: Changes by Don Slutz >>> Switch from xc_domain_getinfo to xc_domain_getinfolist >>> Fix error check for xc_domain_getinfolist >>> Limit increase of maxmem to only do when needed: >>> Add QEMU_SPARE_PAGES (How many pages to leave free) >>> Add free_pages calculation >>> >>> xen-hvm.c | 19 +++++++++++++++++++ >>> 1 file changed, 19 insertions(+) >>> >>> diff --git a/xen-hvm.c b/xen-hvm.c >>> index 7548794..d30e77e 100644 >>> --- a/xen-hvm.c >>> +++ b/xen-hvm.c >>> @@ -90,6 +90,7 @@ static inline ioreq_t *xen_vcpu_ioreq(shared_iopage_t *shared_page, int vcpu) >>> #endif >>> >>> #define BUFFER_IO_MAX_DELAY 100 >>> +#define QEMU_SPARE_PAGES 16 >> >> We need a big comment here to explain why we have this parameter and >> when we'll be able to get rid of it. >> >> Other than that the patch is fine. >> >> Thanks! >> > > Actually I'll just go ahead and add the comment and commit, if for you > is OK. > That would be fine with me. I was still working on a good wording. -Don Slutz > Cheers, > > Stefano >