From: Eyal Perry <eyalpe@dev.mellanox.co.il>
To: Or Gerlitz <gerlitz.or@gmail.com>, Eric Dumazet <eric.dumazet@gmail.com>
Cc: Linux Netdev List <netdev@vger.kernel.org>,
Amir Vadai <amirv@mellanox.com>,
Yevgeny Petrilin <yevgenyp@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Ido Shamay <idos@mellanox.com>, Amir Ancel <amira@mellanox.com>,
Eyal Perry <eyalpe@mellanox.com>
Subject: Re: BW regression after "tcp: refine TSO autosizing"
Date: Tue, 13 Jan 2015 23:41:15 +0200 [thread overview]
Message-ID: <54B590FB.5040805@dev.mellanox.co.il> (raw)
In-Reply-To: <CAJ3xEMibMzJH-AB7pBnO9qBL4McTdsajqHzxXkadnTf1khNdxA@mail.gmail.com>
On 1/13/2015 22:21 PM, Or Gerlitz wrote:
> On Tue, Jan 13, 2015 at 8:57 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
>> On Tue, 2015-01-13 at 18:48 +0200, Eyal Perry wrote:
>>> Hello Eric,
>>> Lately we've observed performance degradation in BW of about 30-40% (depends on
>>> the setup we use).
>>> I've bisected the issue down to the this commit: 605ad7f1 ("tcp: refine TSO
>>> autosizing")
>>>
>>> For instance, I was running the following test:
>>> 1. Bounding net device' irqs to core 0 for both client and server side
>>> 2. Running netperf with 64K massage size (used the following command)
>>> $ netperf -H remote -T 1,1 -l 100 -t TCP_STREAM -- -k THROUGHPUT -M 65536 -m 65536
>>>
>>> I ran the test on upstream net-next including your patch and than reverted it
>>> and these are the results I got was improvement from 14.6Gbps to 22.1Gbps.
>>>
>>> an additional difference I've noticed when inspecting the ethtool statics,
>>> number of xmit_more packets increased from 4 to 160 with the reverted kernel.
>>>
>>> We are investigating this issue, do you have a hint?
>> Which driver are you using for this test ?
> AFAIK, mlx4
Oops, forgot to mention.
mlx4 indeed.
next prev parent reply other threads:[~2015-01-13 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 16:48 BW regression after "tcp: refine TSO autosizing" Eyal Perry
2015-01-13 18:57 ` Eric Dumazet
2015-01-13 20:21 ` Or Gerlitz
2015-01-13 21:41 ` Eyal Perry [this message]
2015-01-13 22:00 ` Eric Dumazet
2015-01-18 16:22 ` Eyal Perry
2015-01-18 17:48 ` Eric Dumazet
2015-01-18 21:40 ` Eyal Perry
2015-01-20 2:16 ` Eric Dumazet
2015-01-20 2:37 ` Dave Taht
2015-01-20 3:14 ` Eric Dumazet
2015-01-20 19:14 ` Rick Jones
2015-01-20 19:26 ` Eric Dumazet
2015-01-20 19:44 ` Rick Jones
2015-01-21 12:26 ` David Laight
2015-01-21 17:01 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B590FB.5040805@dev.mellanox.co.il \
--to=eyalpe@dev.mellanox.co.il \
--cc=amira@mellanox.com \
--cc=amirv@mellanox.com \
--cc=eric.dumazet@gmail.com \
--cc=eyalpe@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=idos@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=yevgenyp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.