Re: [PATCH 1/1] insane.bbclass: Added QA test for expanded ${D}

[Alejandro Hernandez <alejandro.hernandez@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]

Thank Ross, sending new patch soon.
On 07/01/15 12:27, Burton, Ross wrote:
> Hi Alejandro,
>
> Looks good, but some small points:
>
> On 11 December 2014 at 22:40, Alejandro Hernandez 
> <alejandro.hernandez@linux.intel.com 
> <mailto:alejandro.hernandez@linux.intel.com>> wrote:
>
>     -           version-going-backwards \
>     +            version-going-backwards expanded_d \
>
>     +QAPATHTEST[expanded_d] = "package_qa_check_expanded_d"
>
>
> Rename this to expanded-d for consistency with the other symbols that 
> use - instead of _.
>
>     +           # Variables are actually var_${PN}
>
>
> No need to document idioms, remove this comment.
>
>     +                       messages["expanded_d"] = "FILES should not
>     contain the ${D} variable as it references the local build
>     directory not the target filesystem, best solution is to remove
>     the ${D} reference"
>
>
> This doesn't name the package which makes it tricky to find in large 
> builds.
>
> Ross
>


[-- Attachment #2: Type: text/html, Size: 3022 bytes --]