From: hanjun.guo@linaro.org (Hanjun Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: allow late use of early_ioremap
Date: Wed, 14 Jan 2015 16:22:08 +0800 [thread overview]
Message-ID: <54B62730.6090107@linaro.org> (raw)
In-Reply-To: <1421089778.12632.2.camel@t520.localdomain>
Hi Mark,
On 2015?01?13? 03:09, Mark Salter wrote:
> On Mon, 2015-01-12 at 17:25 +0000, Will Deacon wrote:
>> On Mon, Jan 12, 2015 at 04:55:11PM +0000, Mark Salter wrote:
>>> Commit 0e63ea48b4d8 (arm64/efi: add missing call to early_ioremap_reset())
>>> added a missing call to early_ioremap_reset(). This triggers a BUG if code
>>> tries using early_ioremap() after the early_ioremap_reset(). This is a
>>> problem for some ACPI code which needs short-lived temporary mappings
>>> after paging_init() but before mm_init(). This patch adds definitions for
Minor update:
... after paging_init() but before acpi_early_init() in start_kernel().
In ACPI, permanent mapping will be used after acpi_gbl_permanent_mmap
set to 1 in acpi_early_init(), since GIC init and Arch timer init will
be called before acpi_early_init(), early_ioremap() is still needed
after mm_init().
>>> the __late_set_fixmap() and __late_clear_fixmap() which avoids the BUG
>>> by allowing later use of early_ioremap().
>>>
>>> Signed-off-by: Mark Salter <msalter@redhat.com>
>>> CC: Leif Lindholm <leif.lindholm@linaro.org>
>>> CC: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> ---
>>> arch/arm64/include/asm/fixmap.h | 3 +++
>>> 1 file changed, 3 insertions(+)
>>
>> Given that we don't support ACPI on arm64 in mainline, I assume this can
>> wait until at least 3.20?
>
> Sure. Just needs it to go in before ACPI code. And tbh, the ACPI code
> could change and make this unneeded.
This is the best solution for now, so I need to add this patch as the
first one for ACPI core patch set, is it ok for you?
Thanks
Hanjun
WARNING: multiple messages have this Message-ID (diff)
From: Hanjun Guo <hanjun.guo@linaro.org>
To: Mark Salter <msalter@redhat.com>, Will Deacon <will.deacon@arm.com>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] arm64: allow late use of early_ioremap
Date: Wed, 14 Jan 2015 16:22:08 +0800 [thread overview]
Message-ID: <54B62730.6090107@linaro.org> (raw)
In-Reply-To: <1421089778.12632.2.camel@t520.localdomain>
Hi Mark,
On 2015年01月13日 03:09, Mark Salter wrote:
> On Mon, 2015-01-12 at 17:25 +0000, Will Deacon wrote:
>> On Mon, Jan 12, 2015 at 04:55:11PM +0000, Mark Salter wrote:
>>> Commit 0e63ea48b4d8 (arm64/efi: add missing call to early_ioremap_reset())
>>> added a missing call to early_ioremap_reset(). This triggers a BUG if code
>>> tries using early_ioremap() after the early_ioremap_reset(). This is a
>>> problem for some ACPI code which needs short-lived temporary mappings
>>> after paging_init() but before mm_init(). This patch adds definitions for
Minor update:
... after paging_init() but before acpi_early_init() in start_kernel().
In ACPI, permanent mapping will be used after acpi_gbl_permanent_mmap
set to 1 in acpi_early_init(), since GIC init and Arch timer init will
be called before acpi_early_init(), early_ioremap() is still needed
after mm_init().
>>> the __late_set_fixmap() and __late_clear_fixmap() which avoids the BUG
>>> by allowing later use of early_ioremap().
>>>
>>> Signed-off-by: Mark Salter <msalter@redhat.com>
>>> CC: Leif Lindholm <leif.lindholm@linaro.org>
>>> CC: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> ---
>>> arch/arm64/include/asm/fixmap.h | 3 +++
>>> 1 file changed, 3 insertions(+)
>>
>> Given that we don't support ACPI on arm64 in mainline, I assume this can
>> wait until at least 3.20?
>
> Sure. Just needs it to go in before ACPI code. And tbh, the ACPI code
> could change and make this unneeded.
This is the best solution for now, so I need to add this patch as the
first one for ACPI core patch set, is it ok for you?
Thanks
Hanjun
next prev parent reply other threads:[~2015-01-14 8:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 16:55 [PATCH] arm64: allow late use of early_ioremap Mark Salter
2015-01-12 16:55 ` Mark Salter
2015-01-12 17:25 ` Will Deacon
2015-01-12 17:25 ` Will Deacon
2015-01-12 19:09 ` Mark Salter
2015-01-12 19:09 ` Mark Salter
2015-01-14 8:22 ` Hanjun Guo [this message]
2015-01-14 8:22 ` Hanjun Guo
2015-01-14 15:16 ` Mark Salter
2015-01-14 15:16 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B62730.6090107@linaro.org \
--to=hanjun.guo@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.