From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 14 Jan 2015 09:33:53 +0100 Subject: [PATCH 1/4] rtc: armada38x: Add the device tree binding documentation In-Reply-To: <87iogai8sc.fsf@natisbad.org> References: <1420817565-28800-1-git-send-email-gregory.clement@free-electrons.com> <1420817565-28800-2-git-send-email-gregory.clement@free-electrons.com> <87iogai8sc.fsf@natisbad.org> Message-ID: <54B629F1.7060605@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnaud, First, thanks for your extensive review. On 14/01/2015 00:02, Arnaud Ebalard wrote: > Hi Gregory, > > Gregory CLEMENT writes: > >> The Armada 38x SoCs come with a new RTC which differs from the one >> used in the other mvebu SoCs until now. This patch describes the >> binding of this RTC. >> >> Signed-off-by: Gregory CLEMENT >> --- >> .../devicetree/bindings/rtc/armada-380-rtc.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/armada-380-rtc.txt >> >> diff --git a/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt b/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt >> new file mode 100644 >> index 000000000000..2c56bef9dd7e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt >> @@ -0,0 +1,17 @@ >> +* Real Time Clock of te Armada 38x SoCs >> + >> +RTC controller for the Armada 38x SoCs >> + >> +Required properties: >> +- compatible : Should be "marvell,armada-380-rtc" >> +- reg: physical base address of the controller and length of memory mapped >> + region. The second entires is for the IP configuration part. > ^^^^^^^ > entry > > I had to read probe function to understand precisely the purpose of each > region, i.e. IMHO the description could be made a bit clearer. Right, and as suggested by Maxime I will use reg-names > >> +- interrupts: IRQ line for the RTC. >> >> + >> +Example: >> + >> +rtc at 184a8 { >> + compatible = "marvell,armada-380-rtc"; >> + reg = <0xa3800 0x20>, <0x184a0 0x0c>; >> + interrupts = ; >> +}; -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 1/4] rtc: armada38x: Add the device tree binding documentation Date: Wed, 14 Jan 2015 09:33:53 +0100 Message-ID: <54B629F1.7060605@free-electrons.com> References: <1420817565-28800-1-git-send-email-gregory.clement@free-electrons.com> <1420817565-28800-2-git-send-email-gregory.clement@free-electrons.com> <87iogai8sc.fsf@natisbad.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87iogai8sc.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnaud Ebalard Cc: Alessandro Zummo , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Boris BREZILLON , Tawfik Bayouk , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Rutland , Nadav Haklai , Lior Amsalem , Ezequiel Garcia , Maxime Ripard , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Arnaud, First, thanks for your extensive review. On 14/01/2015 00:02, Arnaud Ebalard wrote: > Hi Gregory, > > Gregory CLEMENT writes: > >> The Armada 38x SoCs come with a new RTC which differs from the one >> used in the other mvebu SoCs until now. This patch describes the >> binding of this RTC. >> >> Signed-off-by: Gregory CLEMENT >> --- >> .../devicetree/bindings/rtc/armada-380-rtc.txt | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/armada-380-rtc.txt >> >> diff --git a/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt b/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt >> new file mode 100644 >> index 000000000000..2c56bef9dd7e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/armada-380-rtc.txt >> @@ -0,0 +1,17 @@ >> +* Real Time Clock of te Armada 38x SoCs >> + >> +RTC controller for the Armada 38x SoCs >> + >> +Required properties: >> +- compatible : Should be "marvell,armada-380-rtc" >> +- reg: physical base address of the controller and length of memory mapped >> + region. The second entires is for the IP configuration part. > ^^^^^^^ > entry > > I had to read probe function to understand precisely the purpose of each > region, i.e. IMHO the description could be made a bit clearer. Right, and as suggested by Maxime I will use reg-names > >> +- interrupts: IRQ line for the RTC. >> >> + >> +Example: >> + >> +rtc@184a8 { >> + compatible = "marvell,armada-380-rtc"; >> + reg = <0xa3800 0x20>, <0x184a0 0x0c>; >> + interrupts = ; >> +}; -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html