From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 14 Jan 2015 09:38:22 +0100 Subject: [PATCH 4/4] ARM: mvebu: add Device Tree description of RTC on Armada 38x In-Reply-To: <874mrui8r3.fsf@natisbad.org> References: <1420817565-28800-1-git-send-email-gregory.clement@free-electrons.com> <1420817565-28800-5-git-send-email-gregory.clement@free-electrons.com> <874mrui8r3.fsf@natisbad.org> Message-ID: <54B62AFE.1030909@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Arnaud, On 14/01/2015 00:03, Arnaud Ebalard wrote: > Hi Gregory, > > Gregory CLEMENT writes: > >> The Marvell Armada 38x SoCs contains an RTC which differs from the RTC >> used in the other mvebu SoCs until now. This commit adds the Device >> Tree description of this interface at the SoC level. >> >> Signed-off-by: Gregory CLEMENT >> --- >> arch/arm/boot/dts/armada-38x.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi >> index 04fe80d101f8..22909add8889 100644 >> --- a/arch/arm/boot/dts/armada-38x.dtsi >> +++ b/arch/arm/boot/dts/armada-38x.dtsi >> @@ -466,6 +466,12 @@ >> clocks = <&gateclk 4>; >> }; >> >> + rtc at 184a8 { >> + compatible = "marvell,armada-380-rtc"; >> + reg = <0xa3800 0x20>, <0x184a0 0x0c>; >> + interrupts = ; >> + }; >> + > > Out of curiosity, why not naming the node rtc at a3800? Main argument: > least expectation principle when reading the .dtsi and expecting > increasing addresses. Or did I miss sth else? It was a mistake, I should have used the 0xa3800 offset to name it because most of the RTC registers are located here. Thanks, Gregory > > >> sata at a8000 { >> compatible = "marvell,armada-380-ahci"; >> reg = <0xa8000 0x2000>; -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 4/4] ARM: mvebu: add Device Tree description of RTC on Armada 38x Date: Wed, 14 Jan 2015 09:38:22 +0100 Message-ID: <54B62AFE.1030909@free-electrons.com> References: <1420817565-28800-1-git-send-email-gregory.clement@free-electrons.com> <1420817565-28800-5-git-send-email-gregory.clement@free-electrons.com> <874mrui8r3.fsf@natisbad.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <874mrui8r3.fsf-LkuqDEemtHBg9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnaud Ebalard Cc: Alessandro Zummo , rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , Boris BREZILLON , Tawfik Bayouk , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Rutland , Nadav Haklai , Lior Amsalem , Ezequiel Garcia , Maxime Ripard , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Arnaud, On 14/01/2015 00:03, Arnaud Ebalard wrote: > Hi Gregory, > > Gregory CLEMENT writes: > >> The Marvell Armada 38x SoCs contains an RTC which differs from the RTC >> used in the other mvebu SoCs until now. This commit adds the Device >> Tree description of this interface at the SoC level. >> >> Signed-off-by: Gregory CLEMENT >> --- >> arch/arm/boot/dts/armada-38x.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi >> index 04fe80d101f8..22909add8889 100644 >> --- a/arch/arm/boot/dts/armada-38x.dtsi >> +++ b/arch/arm/boot/dts/armada-38x.dtsi >> @@ -466,6 +466,12 @@ >> clocks = <&gateclk 4>; >> }; >> >> + rtc@184a8 { >> + compatible = "marvell,armada-380-rtc"; >> + reg = <0xa3800 0x20>, <0x184a0 0x0c>; >> + interrupts = ; >> + }; >> + > > Out of curiosity, why not naming the node rtc@a3800? Main argument: > least expectation principle when reading the .dtsi and expecting > increasing addresses. Or did I miss sth else? It was a mistake, I should have used the 0xa3800 offset to name it because most of the RTC registers are located here. Thanks, Gregory > > >> sata@a8000 { >> compatible = "marvell,armada-380-ahci"; >> reg = <0xa8000 0x2000>; -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html