From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBNo3-0008MQ-Ek for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:16:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBNny-0003E7-BT for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:16:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBNny-0003E3-2h for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:16:14 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0EDGCf1025325 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 14 Jan 2015 08:16:13 -0500 Message-ID: <54B66C1B.6090401@redhat.com> Date: Wed, 14 Jan 2015 06:16:11 -0700 From: Eric Blake MIME-Version: 1.0 References: <1421171432-8733-1-git-send-email-armbru@redhat.com> <1421171432-8733-3-git-send-email-armbru@redhat.com> In-Reply-To: <1421171432-8733-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t61SPOtogaGcq7N3EPRSKwpWdQjX8v83u" Subject: Re: [Qemu-devel] [PATCH 2/9] qmp hmp: Improve error messages when SPICE is not in use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kraxel@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --t61SPOtogaGcq7N3EPRSKwpWdQjX8v83u Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/13/2015 10:50 AM, Markus Armbruster wrote: > Commit 7572150 adopted QERR_DEVICE_NOT_ACTIVE for the purpose, > probably because adding another error seemed cumbersome overkill. > Produces "No spice device has been activated", which is awkward. >=20 > We've since abandoned our quest for "rich" error objects. Time to > undo the damage to this error message. Replace it by "SPICE is not in > use". >=20 > Keep the stupid DeviceNotActive ErrorClass for compatibility, even > though Libvirt doesn't use it. Libvirt has a few places that look explicitly for "DeviceNotActive" when deciding how to handle failure reporting; I didn't audit closely enough to see if it actually changes behavior if the class were to disappear. Your approach in this patch is safest, at any rate. >=20 > Signed-off-by: Markus Armbruster > --- > include/ui/qemu-spice.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --t61SPOtogaGcq7N3EPRSKwpWdQjX8v83u Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUtmwbAAoJEKeha0olJ0NqxI0H/3kz7g4eEshfArICEsC+2v9d n4rFWiZMH+/joPfyKIl9Tvliv5vVYxJePVYvOAr6uFSvgv4HVHfATch3izeCC5X9 pFKiCwYOv814RTdEPSt0XgKT2ut9CwMee4kdZkdGWTJP7jF64aqeUNtTgxDmHwH3 79MaGPWF1/Cw7SzWIIB5uN8Fi7JpEgDqsEoTRNrc+ybOHPWdjPkSVaeHcSa4DBCd jcLuIYgvWnQtF8SR5pvEJDvTTYQPyGvONrA2FUxvQVs3tVCGmqFV1RQNqKgFXJWI 1+nCrki0H6V0ybjh5NlCFbxKW+L0x/GhktXXF09mkRI1r5uMsh/37aTLdYB4Wts= =ooMA -----END PGP SIGNATURE----- --t61SPOtogaGcq7N3EPRSKwpWdQjX8v83u--