From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34813) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBO2t-0008Rm-Sn for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:31:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBO2o-0007zP-PX for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:31:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45599) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBO2o-0007zE-I1 for qemu-devel@nongnu.org; Wed, 14 Jan 2015 08:31:34 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t0EDVXVm008063 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 14 Jan 2015 08:31:34 -0500 Message-ID: <54B66FB5.6000101@redhat.com> Date: Wed, 14 Jan 2015 06:31:33 -0700 From: Eric Blake MIME-Version: 1.0 References: <1421171432-8733-1-git-send-email-armbru@redhat.com> <1421171432-8733-10-git-send-email-armbru@redhat.com> In-Reply-To: <1421171432-8733-10-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="b1Gpr8DlRSA6Uq7TbIu6WgHcpiatOAqF0" Subject: Re: [Qemu-devel] [PATCH 9/9] balloon: Eliminate silly QERR_ macros List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kraxel@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --b1Gpr8DlRSA6Uq7TbIu6WgHcpiatOAqF0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/13/2015 10:50 AM, Markus Armbruster wrote: > The QERR_ macros are leftovers from the days of "rich" error objects. > They're used with error_set() and qerror_report(), and expand into the > first *two* arguments. This trickiness has become pointless. Clean > up. I like your wording in 6/9 better ("Clean this one up"), as it is more obvious that you are only fixing a subset and not eliminating all such macros. >=20 > Signed-off-by: Markus Armbruster > --- > balloon.c | 6 ++++-- > include/qapi/qmp/qerror.h | 6 ------ > 2 files changed, 4 insertions(+), 8 deletions(-) >=20 For this patch, and for all others in the series where I did not explicitly reply, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --b1Gpr8DlRSA6Uq7TbIu6WgHcpiatOAqF0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJUtm+1AAoJEKeha0olJ0NqUTgH/Rej/PHJRTAWSi7aTxTpd+E/ vPALZ7OgMluOuvRhm0mNWOUAFe2fO8vV0lfEMfwUq5gN0lPQFvvW8j3swL9N/r1r jATs7MPabh7iSmQ4WJYLdrA6poyBuKAMb6A8YgQ3/q1EeaEfmGK6en+lt4N5mHTB GqkSb51qshxNxyCwfOs6BWEBzDLTNyqbo9q181N/0+wxFVxAsxTcF+7VyEucLsLB VcYW5CfyNmrLaujGHhbsBJcpu4Bip3Nsq1ZbsCGp4Qm6IfOy4aJzcwMvdvhEmIlp N1jTsZeIhuMH/0cF3nbDCq3DUrUNdATjWnQglIF5PNfvy39VaCznw99a+CRBTtg= =KQkD -----END PGP SIGNATURE----- --b1Gpr8DlRSA6Uq7TbIu6WgHcpiatOAqF0--