From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] libxc: introduce a per architecture scratch
 pfn for temporary grant mapping
Date: Wed, 14 Jan 2015 13:32:31 +0000
Message-ID: <54B66FEF.8000502@linaro.org>
References: <1421179848-31833-1-git-send-email-julien.grall@linaro.org>
	<1421233437.19103.216.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YBO4D-00051t-TK
	for xen-devel@lists.xenproject.org; Wed, 14 Jan 2015 13:33:02 +0000
Received: by mail-wi0-f176.google.com with SMTP id z2so2464222wiv.3
	for <xen-devel@lists.xenproject.org>;
	Wed, 14 Jan 2015 05:33:00 -0800 (PST)
In-Reply-To: <1421233437.19103.216.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Jan Beulich <jbeulich@suse.com>, xen-devel@lists.xenproject.org, =?UTF-8?B?Um9nZXIgUGF1IE1vbm7DqQ==?= <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

On 14/01/15 11:03, Ian Campbell wrote:
>> +int
>> +xc_core_arch_get_scratch_gpfn(xc_interface *xch, domid_t domid,
>> +                              xen_pfn_t *gpfn)
>> +{
>> +    int rc;
>> +
>> +    rc = xc_domain_maximum_gpfn(xch, domid);
>> +
>> +    if ( rc <= 0 )
>> +        return rc;
>> +
>> +    *gpfn = rc;
> 
> Shouldn't this be rc + 1 to match the old behaviour?

Oh right. I will fix it in the next version.

Regards,

-- 
Julien Grall