From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, linux-crypto@vger.kernel.org,
qat-linux@intel.com, linux-api@vger.kernel.org
Subject: Re: [PATCH] crypto: algif - change algif_skcipher to be asynchronous
Date: Wed, 14 Jan 2015 09:36:57 -0800 [thread overview]
Message-ID: <54B6A939.4070207@intel.com> (raw)
In-Reply-To: <20150114053805.GA15204@gondor.apana.org.au>
Hi Herbert,
On 01/13/2015 09:38 PM, Herbert Xu wrote:
> What you want is AIO so we should try to use that interface rather
> than creating some funky crypto-specific interface.
>
> Dave, the AIO hooks in net/socket.c is currently simply pointing
> to the sync implementation. What are you thoughts on allowing
> socket implementations to supply these hooks?
>
> The algif interface can then use these hooks to implement AIO
> which is useful for maximising the hardware performance without
> resorting to loads of threads.
But then would you like to extend AIO interface to take the IV and
something that would indicate the encrypt/decrypt operation on
aio_write()? Also as far as I can see AIO doesn't support splice()
operation for zero copy, which is the main thing here.
>From the other hand it shouldn't be a problem to add crypto specific
stuff to include/uapi/linux/if_alg.h, because it is all about crypto
anyway, is it not?
If you have a better way how to indicate that data processing should
start on the last page in sendpage() instead of ALG_OP_IN_PLACE I would
be happy to use it.
Thanks,
Tadeusz
next prev parent reply other threads:[~2015-01-14 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 20:28 [PATCH] crypto: algif - change algif_skcipher to be asynchronous Tadeusz Struk
2015-01-14 5:38 ` Herbert Xu
2015-01-14 17:36 ` Tadeusz Struk [this message]
2015-01-16 2:00 ` Herbert Xu
[not found] ` <20150116020052.GB5851-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-01-23 22:40 ` Tadeusz Struk
[not found] ` <54C2CDF8.3000406-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2015-01-26 2:57 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B6A939.4070207@intel.com \
--to=tadeusz.struk@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-api@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.