From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [PATCH net-next] bridge: fix setlink/dellink notifications Date: Wed, 14 Jan 2015 15:54:36 -0800 Message-ID: <54B701BC.4090209@cumulusnetworks.com> References: <1421218123-18346-1-git-send-email-roopa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , "shemminger@vyatta.com" , "vyasevic@redhat.com" , "john.fastabend@gmail.com" , "tgraf@suug.ch" , "jhs@mojatatu.com" , "sfeldma@gmail.com" , "jiri@resnulli.us" , "wkok@cumulusnetworks.com" To: "Arad, Ronen" Return-path: Received: from mail-pd0-f177.google.com ([209.85.192.177]:51651 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbbANXyh (ORCPT ); Wed, 14 Jan 2015 18:54:37 -0500 Received: by mail-pd0-f177.google.com with SMTP id ft15so12674657pdb.8 for ; Wed, 14 Jan 2015 15:54:37 -0800 (PST) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 1/14/15, 3:22 PM, Arad, Ronen wrote: > >> -----Original Message----- >> From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On >> Behalf Of roopa@cumulusnetworks.com >> Sent: Tuesday, January 13, 2015 10:49 PM >> To: netdev@vger.kernel.org; shemminger@vyatta.com; vyasevic@redhat.com; >> john.fastabend@gmail.com; tgraf@suug.ch; jhs@mojatatu.com; sfeldma@gmail.com; >> jiri@resnulli.us >> Cc: wkok@cumulusnetworks.com >> Subject: [PATCH net-next] bridge: fix setlink/dellink notifications >> >> From: Roopa Prabhu >> > [..] >> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c >> index d06107d..4ac79ff 100644 >> --- a/net/core/rtnetlink.c >> +++ b/net/core/rtnetlink.c >> @@ -2876,13 +2876,6 @@ static int rtnl_bridge_notify(struct net_device *dev, >> u16 flags) > The 'flags' argument was only used for applying the same handling of > MASTER/SELF flags to notification as used for setlink/delink. > This patch eliminates the MASTER case and leaves only SELF notification. > It seems clearer to eliminate flags argument and rename the function to > something like rtnl_bridge_self_notify(). sure, if that makes it clearer. Thanks, Roopa