From: "Fan Chengniang/樊成酿" <fancn.fnst@cn.fujitsu.com>
To: <dsterba@suse.cz>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 RESEND] btrfs-progs: make btrfs qgroups show human readable sizes
Date: Thu, 15 Jan 2015 09:17:01 +0800 [thread overview]
Message-ID: <54B7150D.20903@cn.fujitsu.com> (raw)
In-Reply-To: <20150114154633.GU3685@twin.jikos.cz>
在 2015年01月14日 23:46, David Sterba 写道:
> On Tue, Jan 13, 2015 at 01:53:39PM +0800, Fan Chengniang wrote:
>> make btrfs qgroups show human readable sizes
>> using --human-readable option, example:
> That's too long to type and the idea was to add all the long options
> that force the specific unit base, ie. --kbytes/--mbytes/..., --raw,
> --si and --iec. We can possibly make the human readable the default
> because that's what I'd expect to see to have a quick overview and can
> use the other options otherwise.
>
> The geopt parser accepts short options if they're unique, so --kb or
> even --k works as a very convenient shorcut for frequent commandline
> use.
I have sent a mail for your advise of adding options. In that mail, I
asked whether I should use --human-readable and add --kbytes --mbytes ...
But you have not reply to me.
So, your advise is add --kbytes --mbytes ... and make human-readable
default behaviour?
>> qgroupid rfer excl max_rfer max_excl parent child
>> -------- ---- ---- -------- -------- ------ -----
>> 0/5 299.58MiB 299.58MiB 400.00MiB 0.00B 1/1 ---
>> 0/265 299.58MiB 16.00KiB 0.00B 320.00MiB 1/1 ---
>> 0/266 299.58MiB 16.00KiB 350.00MiB 0.00B --- ---
>> 1/1 599.16MiB 299.59MiB 800.00MiB 0.00B --- 0/5,0/265
> The values should be also aligned to the right.
It is aligned to left before my patch. I just keep it.
next prev parent reply other threads:[~2015-01-15 1:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 5:53 [PATCH v2 RESEND] btrfs-progs: make btrfs qgroups show human readable sizes Fan Chengniang
2015-01-14 15:46 ` David Sterba
2015-01-14 18:20 ` Roman Mamedov
2015-01-15 12:02 ` David Sterba
2015-01-15 1:01 ` Qu Wenruo
2015-01-15 12:05 ` David Sterba
2015-01-15 20:41 ` btrfs command completion Was: " Duncan
2015-01-15 1:17 ` Fan Chengniang/樊成酿 [this message]
2015-01-15 12:30 ` David Sterba
2015-01-15 13:50 ` 樊成酿
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7150D.20903@cn.fujitsu.com \
--to=fancn.fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.