All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Congyang <wency@cn.fujitsu.com>
To: Ian.Campbell@citrix.com
Cc: Ian.Jackson@eu.citrix.com, Euan Harris <euan.harris@citrix.com>,
	xen-devel@lists.xen.org
Subject: [PATCH] Fix building error
Date: Thu, 15 Jan 2015 11:39:04 +0800	[thread overview]
Message-ID: <54B73658.6030309@cn.fujitsu.com> (raw)
In-Reply-To: <1417443665-30809-1-git-send-email-euan.harris@citrix.com>

Commit 1166ecf7 disables optimization. But python's build
process may use CFLAGS -Wp,-D_FORTIFY_SOURCE=2, and suppose
the 3rd party python modules to use. The macro _FORTIFY_SOURCE
requires compiling with optimization (-O). Disable _FORTIFY_SOURCE
by appending -Wp,-U_FORTIFY_SOURCE to CFLAGS.

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
---
 tools/pygrub/Makefile | 5 +++++
 tools/python/Makefile | 5 +++++
 2 files changed, 10 insertions(+)

diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
index 3dff608..3d86254 100644
--- a/tools/pygrub/Makefile
+++ b/tools/pygrub/Makefile
@@ -2,6 +2,11 @@
 XEN_ROOT = $(CURDIR)/../..
 include $(XEN_ROOT)/tools/Rules.mk
 
+ifeq ($(debug),y)
+# Disable _FORTIFY_SOURCE
+CFLAGS += -Wp,-U_FORTIFY_SOURCE
+endif
+
 .PHONY: all
 all: build
 .PHONY: build
diff --git a/tools/python/Makefile b/tools/python/Makefile
index 533d3de..3997660 100644
--- a/tools/python/Makefile
+++ b/tools/python/Makefile
@@ -4,6 +4,11 @@ include $(XEN_ROOT)/tools/Rules.mk
 .PHONY: all
 all: build
 
+ifeq ($(debug),y)
+# Disable _FORTIFY_SOURCE
+CFLAGS += -Wp,-U_FORTIFY_SOURCE
+endif
+
 .PHONY: build
 build: genwrap.py $(XEN_ROOT)/tools/libxl/libxl_types.idl \
 		$(XEN_ROOT)/tools/libxl/idl.py
-- 
2.1.0

  parent reply	other threads:[~2015-01-15  3:39 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-01 10:39 [PATCH] libxl/Makefile: Don't optimize debug builds; add macro debugging information Euan Harris
2014-12-01 11:43 ` Ian Campbell
2014-12-01 11:55   ` Euan Harris
2014-12-01 12:12     ` Ian Campbell
2014-12-01 14:21       ` [PATCH v2] tools/Rules.mk: " Euan Harris
2015-01-08 17:16         ` Ian Campbell
2015-01-12 16:42           ` Ian Campbell
2015-01-13  5:52         ` Wen Congyang
2015-01-13 10:11           ` Ian Campbell
2015-01-13 10:38             ` Wen Congyang
2015-01-13 11:17             ` Wen Congyang
2015-01-13 11:30               ` Ian Campbell
2015-01-15  3:38                 ` Wen Congyang
2015-01-15  3:39         ` Wen Congyang [this message]
2015-01-15  7:57           ` [PATCH] Fix building error Olaf Hering
2015-01-15  9:04             ` Wen Congyang
2015-01-15  9:21               ` Olaf Hering
2015-01-15  9:28                 ` Wen Congyang
2015-01-15  9:33                   ` [PATCH v2] " Wen Congyang
2015-01-15 11:26                     ` Ian Jackson
2015-01-19 15:23                       ` Ian Campbell
2015-01-20  2:21                         ` Wen Congyang
2015-01-20 10:18                           ` Ian Campbell
2015-01-20 10:39                             ` Wen Congyang
2015-01-20 12:47                         ` Olaf Hering
2015-01-23 11:34                         ` Julien Grall
2015-02-04 15:37                       ` Jan Beulich
2015-02-04 15:43                         ` Ian Jackson
2015-02-04 16:02                           ` Jan Beulich
2015-02-04 16:10                             ` Ian Jackson
2015-02-04 16:42                         ` Olaf Hering

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B73658.6030309@cn.fujitsu.com \
    --to=wency@cn.fujitsu.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=euan.harris@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.