From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] kexec: fix some types
Date: Thu, 15 Jan 2015 16:05:12 +0000
Message-ID: <54B7E538.5030906@citrix.com>
References: <54B7EB8302000078000557CD@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <david.vrabel@citrix.com>) id 1YBmvs-0001UD-Bu
	for xen-devel@lists.xenproject.org; Thu, 15 Jan 2015 16:06:04 +0000
In-Reply-To: <54B7EB8302000078000557CD@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Keir Fraser <keir@xen.org>, David Vrabel <david.vrabel@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 15/01/15 15:32, Jan Beulich wrote:
> crashinfo_maxaddr can/will be a 64-bit type, hence passing it to fls()
> is wrong.
> 
> crashinfo_maxaddr_bits, otoh, doesn't need to be a paddr_t, and can
> additionally be __initdata.
> 
> struct xen_kexec_reserve's start field - representing a physical
> address - ought to have respective type.

Reviewed-by: David Vrabel <david.vrabel@citrix.com>

David