From: Gabriel de Perthuis <g2p.code@gmail.com>
To: stable@vger.kernel.org
Cc: bcache <linux-bcache@vger.kernel.org>
Subject: [PATCH] bcache: Make sure to pass GFP_WAIT to mempool_alloc()
Date: Thu, 15 Jan 2015 17:26:37 +0100 [thread overview]
Message-ID: <54B7EA3D.7050203@gmail.com> (raw)
this was very wrong - mempool_alloc() only guarantees success with GFP_WAIT.
bcache uses GFP_NOWAIT in various other places where we have a fallback,
circuits must've gotten crossed when writing this code or something.
Signed-off-by: Kent Overstreet <kmo@daterainc.com>
---
The bug was introduced in v3.11, fixed in v3.17.
Jens mentioned bcache has many stable@ candidates previously:
https://lkml.org/lkml/2014/9/5/360
I'm cherry-picking this fix because I was getting crashes.
---
drivers/md/bcache/btree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/btree.c b/drivers/md/bcache/btree.c
index 9dd9f1c..e538d45 100644
--- a/drivers/md/bcache/btree.c
+++ b/drivers/md/bcache/btree.c
@@ -200,11 +200,11 @@ void bch_btree_node_read_done(struct btree *b)
{
const char *err = "bad btree header";
struct bset *i = btree_bset_first(b);
struct btree_iter *iter;
- iter = mempool_alloc(b->c->fill_iter, GFP_NOWAIT);
+ iter = mempool_alloc(b->c->fill_iter, GFP_NOIO);
iter->size = b->c->sb.bucket_size / b->c->sb.block_size;
iter->used = 0;
#ifdef CONFIG_BCACHE_DEBUG
iter->b = &b->keys;
--
2.2.0.71.g3365589
next reply other threads:[~2015-01-15 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 16:26 Gabriel de Perthuis [this message]
2015-01-15 18:35 ` [PATCH] bcache: Make sure to pass GFP_WAIT to mempool_alloc() Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7EA3D.7050203@gmail.com \
--to=g2p.code@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.