From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2] make error codes a formal part of the ABI
Date: Thu, 15 Jan 2015 16:58:35 +0000
Message-ID: <54B7F1BB.1060804@citrix.com>
References: <54B7E9E102000078000557AD@mail.emea.novell.com>
	<54B7EA7E.20800@citrix.com>
	<54B7FD92020000780005589D@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1YBnkm-0006A7-Ta
	for xen-devel@lists.xenproject.org; Thu, 15 Jan 2015 16:58:41 +0000
In-Reply-To: <54B7FD92020000780005589D@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>, Ian Campbell <Ian.Campbell@eu.citrix.com>, xen-devel <xen-devel@lists.xenproject.org>
List-Id: xen-devel@lists.xenproject.org

On 15/01/15 16:49, Jan Beulich wrote:
>>>> On 15.01.15 at 17:27, <andrew.cooper3@citrix.com> wrote:
>> On 15/01/15 15:25, Jan Beulich wrote:
>>> Now that we have two cases where patches against hvmloader got
>>> submitted needing to include the hypervisor's errno.h (for the host's
>>> system header not necessarily reflecting the correct numbers), take
>>> this as a strong sign that we need to make the error return values part
>>> of the hypervisor ABI (which de-fact they've always been).
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> How do the non XEN_ prefixed E$FOO get generated with this?  All
>> "#define XEN_ERRNO(...)" tokenise XEN_## onto the name.
> No:
>
>>> --- a/xen/include/xen/errno.h
>>> +++ b/xen/include/xen/errno.h
>>> [...]
>>> +#ifndef __ASSEMBLY__
>>>  
>>> -#define	ENOMEDIUM	123	/* No medium found */
>>> -#define	EMEDIUMTYPE	124	/* Wrong medium type */
>>> +#define XEN_ERRNO(name, value) name = XEN_##name,
> The XEN_## one is on the right side here ...

Ah - I am clearly blind.

Sorry for the noise.

~Andrew