From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3 13/21] ARM: omap: convert wakeupgen to stacked domains Date: Thu, 15 Jan 2015 17:28:44 +0000 Message-ID: <54B7F8CC.3070901@arm.com> References: <1421087187-26988-1-git-send-email-marc.zyngier@arm.com> <1421087187-26988-14-git-send-email-marc.zyngier@arm.com> <20150114222814.GU2419@atomide.com> <871tmwi0d6.fsf@approximate.cambridge.arm.com> <20150115144016.GA19920@kahuna> <87sifcgksy.fsf@approximate.cambridge.arm.com> <20150115170443.GF18552@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150115170443.GF18552@atomide.com> Sender: linux-samsung-soc-owner@vger.kernel.org To: Tony Lindgren Cc: Nishanth Menon , Stephen Warren , Thierry Reding , Alexandre Courbot , Benoit Cousson , Santosh Shilimkar , Shawn Guo , Sascha Hauer , Kukjin Kim , Simon Horman , Magnus Damm , Linus Walleij , Michal Simek , Rob Herring , Mark Rutland , Jason Cooper , Thomas Gleixner , Stefan Agner , "linux-arm-kernel@lists.infradead.org" , "linux-samsung-soc@vger.kernel.org" , "linux-omap@vger.kernel.org" List-Id: linux-omap@vger.kernel.org On 15/01/15 17:04, Tony Lindgren wrote: > * Marc Zyngier [150115 06:53]: >> On Thu, Jan 15 2015 at 2:40:16 pm GMT, Nishanth Menon wrote: >>> On 14:28-20150115, Marc Zyngier wrote: >>>> Assuming the workaround I posted earlier works, the OMAP/DRA7 part of >>>> this series is going to require some rework too (I need to know where >>>> these legacy interrupts are attached: crossbar, WUGEN, or GIC?). >>>> >>> crossbar will never work with legacy static interrupts anyways - since >>> there was never a static interrupt possible - I believe we had removed >>> all the legacy hardcoded interrupt definitions for DRA7. ideally, they >>> should all be dt only now. >> >> Yes, I guessed as much after looking at the DRA7XX hwmod. >> >> So only OMAP4/5 is b0rken at the moment. I can probably work around it >> as I did in this example patch, just by changing the compatible strings >> for the xlate callback. Very ugly. > > For the -rc, it seems the wakeupen still needs a fix as based on grepping > for OMAP44XX_IRQ_GIC_START. Got any great ideas for that? I think this one is fine. It computes the SPI number based on the hwirq coming from the GIC. That direction is completely unaffected by the linear domain stuff. It is only when you try to use a hardware IRQ as a Linux IRQ that you run into trouble. Thanks, M. -- Jazz is not dead. It just smells funny... From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Thu, 15 Jan 2015 17:28:44 +0000 Subject: [PATCH v3 13/21] ARM: omap: convert wakeupgen to stacked domains In-Reply-To: <20150115170443.GF18552@atomide.com> References: <1421087187-26988-1-git-send-email-marc.zyngier@arm.com> <1421087187-26988-14-git-send-email-marc.zyngier@arm.com> <20150114222814.GU2419@atomide.com> <871tmwi0d6.fsf@approximate.cambridge.arm.com> <20150115144016.GA19920@kahuna> <87sifcgksy.fsf@approximate.cambridge.arm.com> <20150115170443.GF18552@atomide.com> Message-ID: <54B7F8CC.3070901@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 15/01/15 17:04, Tony Lindgren wrote: > * Marc Zyngier [150115 06:53]: >> On Thu, Jan 15 2015 at 2:40:16 pm GMT, Nishanth Menon wrote: >>> On 14:28-20150115, Marc Zyngier wrote: >>>> Assuming the workaround I posted earlier works, the OMAP/DRA7 part of >>>> this series is going to require some rework too (I need to know where >>>> these legacy interrupts are attached: crossbar, WUGEN, or GIC?). >>>> >>> crossbar will never work with legacy static interrupts anyways - since >>> there was never a static interrupt possible - I believe we had removed >>> all the legacy hardcoded interrupt definitions for DRA7. ideally, they >>> should all be dt only now. >> >> Yes, I guessed as much after looking at the DRA7XX hwmod. >> >> So only OMAP4/5 is b0rken at the moment. I can probably work around it >> as I did in this example patch, just by changing the compatible strings >> for the xlate callback. Very ugly. > > For the -rc, it seems the wakeupen still needs a fix as based on grepping > for OMAP44XX_IRQ_GIC_START. Got any great ideas for that? I think this one is fine. It computes the SPI number based on the hwirq coming from the GIC. That direction is completely unaffected by the linear domain stuff. It is only when you try to use a hardware IRQ as a Linux IRQ that you run into trouble. Thanks, M. -- Jazz is not dead. It just smells funny...