From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ed White <edmund.h.white@intel.com>
Subject: Re: [PATCH 05/11] x86/altp2m: basic data structures and
	support routines.
Date: Thu, 15 Jan 2015 10:49:42 -0800
Message-ID: <54B80BC6.50809@intel.com>
References: <1420838801-11704-1-git-send-email-edmund.h.white@intel.com>
	<1420838801-11704-6-git-send-email-edmund.h.white@intel.com>
	<20150115164848.GE57240@deinos.phlegethon.org>
	<54B7FEA802000078000558C0@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54B7FEA802000078000558C0@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Tim Deegan <tim@xen.org>
Cc: keir@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 01/15/2015 08:53 AM, Jan Beulich wrote:
>>>> On 15.01.15 at 17:48, <tim@xen.org> wrote:
>> At 13:26 -0800 on 09 Jan (1420806395), Ed White wrote:
>>> +    /* Init alternate p2m data */
>>> +    if ( (d->arch.altp2m_eptp = alloc_xenheap_page()) == NULL )
>>> +    {
>>> +        rv = -ENOMEM;
>>> +        goto out;
>>> +    }
>>> +    for (i = 0; i < 512; i++)
>>> +        d->arch.altp2m_eptp[i] = ~0ul;
>>
>> This 512 is architectural, I guess?  It should have a named constant.
> 
> Perhaps even calculated rather than just defined as a plain
> number constant, e.g. (PAGE_SIZE / sizeof(something)).

There are architectural reasons why it's very unlikely to change
from 512, so I'll just name it if that's OK.

Ed