From mboxrd@z Thu Jan  1 00:00:00 1970
From: Don Slutz <dslutz@verizon.com>
Subject: Re: [PATCH for-4.5 v7 3/7] vmware: Add VMware provided
	include files.
Date: Thu, 15 Jan 2015 16:36:34 -0500
Message-ID: <54B832E2.4010706@terremark.com>
References: <1412285417-19180-1-git-send-email-dslutz@verizon.com>
	<1412285417-19180-4-git-send-email-dslutz@verizon.com>
	<54B7FCF2020000780005589A@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54B7FCF2020000780005589A@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, Don Slutz <dslutz@verizon.com>
Cc: Jun Nakajima <jun.nakajima@intel.com>, Tim Deegan <tim@xen.org>, Kevin Tian <kevin.tian@intel.com>, Keir Fraser <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, George Dunlap <George.Dunlap@eu.citrix.com>, Andrew Cooper <andrew.cooper3@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org, Eddie Dong <eddie.dong@intel.com>, Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>, Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>
List-Id: xen-devel@lists.xenproject.org

On 01/15/15 11:46, Jan Beulich wrote:
>>>> On 02.10.14 at 23:30, <dslutz@verizon.com> wrote:
>> These 2 files: backdoor_def.h and guest_msg_def.h come from:
>>
>> http://packages.vmware.com/tools/esx/3.5latest/rhel4/SRPMS/index.html 
>>  open-vm-tools-kmod-7.4.8-396269.423167.src.rpm
>>   open-vm-tools-kmod-7.4.8.tar.gz
>>    vmhgfs/backdoor_def.h
>>    vmhgfs/guest_msg_def.h
>>
>> and are unchanged.
> 
> Either the description is wrong, or the patch is stale - there's no
> guest_msg_def.h here.
> 

The commit message is stale.  Missed adjusting for removal of VMware
rpc stuff.  Will Fix.

>> Added the badly named include file includeCheck.h also.  It only
>> has comments and is provided so that backdoor_def.h and
>> guest_msg_def.h can be used without change.
> 
> In which case I'd say a file with a single comment line in it would
> suffice. Such a comment is hardly copyrightable...
> 

Ok, Will make it a single line comment.

   -Don Slutz

> Jan
>