From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Fri, 16 Jan 2015 14:52:06 +0000 Subject: Re: [lm-sensors] [PATCH] hwmon: (ads7828) Make sample interval configurable Message-Id: <54B92596.2040206@roeck-us.net> List-Id: References: <1421409922-28299-1-git-send-email-robert.rosengren@axis.com> In-Reply-To: <1421409922-28299-1-git-send-email-robert.rosengren@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Robert Rosengren , Jean Delvare , lm-sensors@lm-sensors.org Cc: linux-kernel@vger.kernel.org, Robert Rosengren , Johan Adolfsson On 01/16/2015 04:05 AM, Robert Rosengren wrote: > The default sample interval may be too slow for certain clients. This > patch makes it configurable via the platform_data. > > Signed-off-by: Robert Rosengren > Signed-off-by: Johan Adolfsson I am basically fine with the patch, though I would prefer replacing the entire update handling and chip access with regmap. Would you be interested in doing that ? Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754902AbbAPOwP (ORCPT ); Fri, 16 Jan 2015 09:52:15 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:36031 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751795AbbAPOwO (ORCPT ); Fri, 16 Jan 2015 09:52:14 -0500 Message-ID: <54B92596.2040206@roeck-us.net> Date: Fri, 16 Jan 2015 06:52:06 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Robert Rosengren , Jean Delvare , lm-sensors@lm-sensors.org CC: linux-kernel@vger.kernel.org, Robert Rosengren , Johan Adolfsson Subject: Re: [PATCH] hwmon: (ads7828) Make sample interval configurable References: <1421409922-28299-1-git-send-email-robert.rosengren@axis.com> In-Reply-To: <1421409922-28299-1-git-send-email-robert.rosengren@axis.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020204.54B9259D.0305,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 3 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/16/2015 04:05 AM, Robert Rosengren wrote: > The default sample interval may be too slow for certain clients. This > patch makes it configurable via the platform_data. > > Signed-off-by: Robert Rosengren > Signed-off-by: Johan Adolfsson I am basically fine with the patch, though I would prefer replacing the entire update handling and chip access with regmap. Would you be interested in doing that ? Thanks, Guenter