From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v1 3/3] xen/arm: Introduce support for Renesas R-Car Gen2 platform Date: Fri, 16 Jan 2015 15:32:51 +0000 Message-ID: <54B92F23.7060507@linaro.org> References: <1421412610-19313-1-git-send-email-oiurii.konovalenko@globallogic.com> <1421412610-19313-4-git-send-email-oiurii.konovalenko@globallogic.com> <54B91B56.1060206@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Iurii Konovalenko Cc: Oleksandr Tyshchenko , Stefano Stabellini , tim@xen.org, Ian Campbell , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 16/01/15 15:29, Iurii Konovalenko wrote: >> Is there any reason that this code diverge? >> > > Linux kernel 3.14-ltsi, which I used as a reference, use CNTFID0 > in file arch/arm/mach-shmobile/setup-rcar-gen2.c: > iowrite32(freq, base + CNTFID0); Which seems different from upstream: 1. /* Update registers with correct frequency */ 2. iowrite32(freq, base + CNTFID0); 3. asm volatile("mcr p15, 0, %0, c14, c0, 0" : : "r" (freq)); 4. 5. /* make sure arch timer is started by setting bit 0 of CNTCR */ 6. iowrite32(1, base + CNTCR); Regards, -- Julien Grall