From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59072) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCBz8-0004zY-3w for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:51:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YCBz2-00078J-Uc for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:51:06 -0500 Received: from mail-qc0-x22c.google.com ([2607:f8b0:400d:c01::22c]:36299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YCBz2-000789-Po for qemu-devel@nongnu.org; Fri, 16 Jan 2015 13:51:00 -0500 Received: by mail-qc0-f172.google.com with SMTP id i8so9700555qcq.3 for ; Fri, 16 Jan 2015 10:50:59 -0800 (PST) Sender: Richard Henderson Message-ID: <54B95D8F.3090704@twiddle.net> Date: Fri, 16 Jan 2015 10:50:55 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1421334118-3287-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1421334118-3287-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Paolo Bonzini , Riku Voipio , patches@linaro.org On 01/15/2015 07:01 AM, Peter Maydell wrote: > I was looking at our confusing mess of memory accessor functions, > and I realised that partly it was confusing because we have a > bunch of unnecessary junk lurking in there :-) This series > attempts to clean things up by removing things we weren't using > at all or were only using by mistake in a few places: > > * ldul_*: not used > * ld* (ldl, etc): hardly used > * ld*_kernel: not used > * ld*_raw: hardly used > * cpu_{ld,st}{fq,fl}: not used > > The dull parts of this series are removing the unused macros > and fixing uses of the hardly-used macros so those can be > deleted too. This series also switches to using inline functions > rather than macros for the user-only cpu_ld/st* accessors, bringing > them into line with the softmmu configs. This has the nice > side effect of letting us get rid of the _raw accessor macros too. > I've also thrown in a commit which cleans up the doc comments. > > Peter Maydell (15): > cpu_ldst.h: Remove unused ldul_ macros > monitor.c: Use ld*_p() instead of ld*_raw() > target-sparc: Don't use {ld,st}*_raw functions > linux-user/elfload.c: Don't use _raw accessor functions > bsd-user/elfload.c: Don't use ldl() or ldq_raw() > linux-user/vm86.c: Use cpu_ldl_data &c rather than plain ldl &c > linux-user/main.c (m68k): Use get_user_u16 rather than lduw in > cpu_loop > target-mips: Don't use _raw load/store accessors > cpu_ldst.h: Drop unused ld/st*_kernel defines > cpu_ldst.h: Remove unused very short ld*/st* defines > cpu_ldst.h: Use inline functions for usermode cpu_ld/st accessors > cpu_ldst_template.h: Use ld*_p directly rather than via ld*_raw macros > cpu_ldst.h: Drop unused _raw macros, saddr() and laddr() > cpu_ldst_template.h: Drop unused cpu_ldfq/stfq/ldfl/stfl accessors > cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st > accessors Reviewed-by: Richard Henderson Nice cleanup. r~