All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] cpu_ldst.h: Don't define helpers if MMU_MODE*_SUFFIX not defined
Date: Fri, 16 Jan 2015 10:51:18 -0800	[thread overview]
Message-ID: <54B95DA6.1040906@twiddle.net> (raw)
In-Reply-To: <1421432008-6786-1-git-send-email-peter.maydell@linaro.org>

On 01/16/2015 10:13 AM, Peter Maydell wrote:
> Not all targets define a full set of suffix strings for the
> NB_MMU_MODES that they have. In this situation, don't define any
> helper functions for that mode, rather than defining helper functions
> with no suffix at all. The MMU mode is still functional; it is merely
> not directly accessible via cpu_ld*_MODE from target helper functions.
> 
> Also add an "NB_MMU_MODES >= 2" check to the definition of the mode 1
> helpers -- some targets only define one MMU mode.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~

      reply	other threads:[~2015-01-16 18:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16 18:13 [Qemu-devel] [PATCH] cpu_ldst.h: Don't define helpers if MMU_MODE*_SUFFIX not defined Peter Maydell
2015-01-16 18:51 ` Richard Henderson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B95DA6.1040906@twiddle.net \
    --to=rth@twiddle.net \
    --cc=patches@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.