Re: [PATCH net 1/2] sh_eth: Fix promiscuous mode on chips without TSU

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

On 01/16/2015 10:27 PM, Sergei Shtylyov wrote:

>> Currently net_device_ops::set_rx_mode is only implemented for
>> chips with a TSU (multiple address table).  However we do need
>> to turn the PRM (promiscuous) flag on and off for other chips.

[...]

>> Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>

[...]

>> diff --git a/drivers/net/ethernet/renesas/sh_eth.c
>> b/drivers/net/ethernet/renesas/sh_eth.c
>> index 167737f..0c4d5b5 100644
>> --- a/drivers/net/ethernet/renesas/sh_eth.c
>> +++ b/drivers/net/ethernet/renesas/sh_eth.c
[...]
>> @@ -2440,7 +2440,7 @@ static void sh_eth_tsu_purge_mcast(struct net_device
>> *ndev)
>>       void *reg_offset = sh_eth_tsu_get_offset(mdp, TSU_ADRH0);
>>       int i;
>>
>> -    if (unlikely(!mdp->cd->tsu))
>> +    if (!mdp->cd->tsu)

>     But we don't call this function on non-TSU SoCs, do we?

    Sorry, we do.

> [...]

WBR, Sergei