From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ed White Subject: Re: [PATCH 00/11] Alternate p2m: support multiple copies of host p2m Date: Fri, 16 Jan 2015 12:32:12 -0800 Message-ID: <54B9754C.60104@intel.com> References: <1420838801-11704-1-git-send-email-edmund.h.white@intel.com> <20150115161519.GA57240@deinos.phlegethon.org> <54B805B0.8090604@intel.com> <20150116183306.GJ48064@deinos.phlegethon.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150116183306.GJ48064@deinos.phlegethon.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tim Deegan Cc: keir@xen.org, ian.jackson@eu.citrix.com, ian.campbell@citrix.com, jbeulich@suse.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org > >> As I said in discussion with Andrew, my aim was to make it possible >> for these same changes to be extensible to AMD processors if they >> support multiple copies of whatever their EPT equivalent is, by >> simply emulating VMFUNC and #VE. That's why there are some wrappers >> in the implementation that appear redundant. > > Yep, understood, and thank you for that. But I think there was one > function (to find a p2m by eptp) that's defined in vmx.c and only ever > called from there -- that doesn't need an arch-specific wrapper, > because an eventual AMD equivalent would also be entirely contained > within svm.c. > I think you're referring to p2m_find_altp2m_by_eptp(), defined in p2m.c but only called from vmx.c. That might more properly be p2m_find_altp2m_by_whatever_the_hardware_uses(), which is why I put it there. I assumed it would have value for AMD. Ed